Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy benchmarks for cuDF-python #14591

Merged
merged 6 commits into from
Dec 10, 2023
Merged

Remove legacy benchmarks for cuDF-python #14591

merged 6 commits into from
Dec 10, 2023

Conversation

osidekyle
Copy link
Contributor

@osidekyle osidekyle commented Dec 7, 2023 •
edited
Loading

Description

This PR removes the legacy benchmarks within the python/cudf/cudf/benchmarks directory and the "excludes" reference to these benchmarks in pyproject.toml. Closes #14573.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 7, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Dec 7, 2023
@shwina
Copy link
Contributor

shwina commented Dec 7, 2023

/ok to test

@shwina shwina added code quality non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Dec 7, 2023
@osidekyle osidekyle marked this pull request as ready for review December 7, 2023 23:40
@osidekyle osidekyle requested a review from a team as a code owner December 7, 2023 23:40
@osidekyle
Copy link
Contributor Author

@shwina Are there any other steps I need to take to make this PR eligible for review? I see the "pr-builder" check has yet to complete.

@shwina
Copy link
Contributor

shwina commented Dec 8, 2023

Thank you, @osidekyle -- no, it's looking great! After CI passes, I'll go ahead and merge. Thanks so much for the contribution!

shwina
shwina approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@galipremsagar could you also take a quick look to ensure nothing was missed?

@osidekyle
Copy link
Contributor Author

Thank you, @osidekyle -- no, it's looking great! After CI passes, I'll go ahead and merge. Thanks so much for the contribution!

great! I am curious, I can't seem to find where this CI is running in the "Actions" tab or by just clicking on it here in the PR. Am I able to view the run somewhere?

@shwina
Copy link
Contributor

shwina commented Dec 8, 2023

/ok to test

@shwina
Copy link
Contributor

shwina commented Dec 8, 2023

Ah, when the PR submitter is not part of the rapidsai org, the CI checks need a team member to comment /ok to test in order to be kicked off.

You can see the progress here: https://github.com/rapidsai/cudf/actions/runs/7145162927

@shwina
Copy link
Contributor

shwina commented Dec 8, 2023 •
edited
Loading

Just FYI the failed C++ tests are due to a race condition bug being addressed in #14598.

@shwina
Copy link
Contributor

shwina commented Dec 9, 2023

/ok to test

@shwina
Copy link
Contributor

shwina commented Dec 10, 2023

/merge

@rapids-bot rapids-bot bot merged commit 759a1c8 into rapidsai:branch-24.02 Dec 10, 2023
70 checks passed
karthikeyann pushed a commit to karthikeyann/cudf that referenced this pull request Dec 12, 2023
@osidekyle @karthikeyann
Remove legacy benchmarks for cuDF-python (rapidsai#14591)
8145c67 
This PR removes the legacy benchmarks within the python/cudf/cudf/benchmarks directory and the "excludes" reference to these benchmarks in pyproject.toml. Closes rapidsai#14573.

Authors:
  - Kyle Hawkins (https://github.com/osidekyle)
  - Ashwin Srinath (https://github.com/shwina)

Approvers:
  - Ashwin Srinath (https://github.com/shwina)

URL: rapidsai#14591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Remove the directory python/cudf/cudf/benchmarks and its contents
2 participants
@osidekyle @shwina