Unconditionally export the CCCL path #14656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
libcudf
|
I downloaded these artifacts into a cuspatial devcontainer and verified that it fixed the build issues observed in rapidsai/cuspatial#1315. |
3 tasks
robertmaynard
requested changes
Dec 20, 2023
robertmaynard
approved these changes
Dec 20, 2023
|
/merge |
1 similar comment
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to unconditionally export the CCCL path because the condition can no longer be evaluated since the export is happening before the call to
rapids_cpm_ccclas of #14655. Since cudf should in practice always be getting its own local copy of CCCL, it should be safe to have this export unconditionally; we will never use an externally provided copy of CCCL.Checklist