Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential fix for peformance regression in #14415 #14706

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Potential fix for peformance regression in #14415 #14706

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cca9be6
do not exit loop prematurely on error
etseidl Jan 3, 2024
14fd85c
Merge branch 'branch-24.02' into fix_14415
vuule Jan 3, 2024
d8ba3fc
Merge branch 'branch-24.02' into fix_14415
vuule Jan 4, 2024
d240f91
Merge branch 'branch-24.02' into fix_14415
vuule Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions cpp/src/io/parquet/page_decode.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2018-2023, NVIDIA CORPORATION.
* Copyright (c) 2018-2024, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -506,14 +506,9 @@ __device__ void gpuDecodeStream(
cur++;
}
}
if (cur > end) {
s->set_error_code(decode_error::LEVEL_STREAM_OVERRUN);
break;
}
if (level_run <= 1) {
s->set_error_code(decode_error::INVALID_LEVEL_RUN);
break;
}
// If there are errors, set the error code and continue. The loop will be exited below.
if (cur > end) { s->set_error_code(decode_error::LEVEL_STREAM_OVERRUN); }
if (level_run <= 1) { s->set_error_code(decode_error::INVALID_LEVEL_RUN); }
GregoryKimball marked this conversation as resolved.
Show resolved Hide resolved
sym_len = (int32_t)(cur - cur_def);
__threadfence_block();
}
Expand Down