Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove **kwargs from astype #14765

Merged
merged 6 commits into from
Jan 19, 2024
Merged

Remove **kwargs from astype #14765

merged 6 commits into from
Jan 19, 2024

Conversation

mroeschke
Copy link
Contributor

Description

The aligns with pandas's behavior of astype which doesn't accept kwargs. AFAICT, **kwargs was never really respected in the first place

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function breaking Breaking change labels Jan 16, 2024
@mroeschke mroeschke requested a review from a team as a code owner January 16, 2024 22:08
isVoid
isVoid approved these changes Jan 18, 2024
View reviewed changes
python/cudf/cudf/tests/test_dataframe.py Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor

vyasr commented Jan 19, 2024

/merge

@rapids-bot rapids-bot bot merged commit 51ecef3 into rapidsai:branch-24.02 Jan 19, 2024
66 of 67 checks passed
@mroeschke mroeschke deleted the ref/astype/kwargs branch January 19, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mroeschke @vyasr @isVoid