Fix ptx file discovery in editable installs #14767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
bdice
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Looks fine to me. Be aware of potential conflicts with #13690. cc: @brandon-b-miller
|
Yeah I was reviewing that PR as well. I'll help Brandon deal with it as soon as this is merged. |
|
/merge |
|
Thanks! I think I encountered this before break #14653 (comment) |
|
Ah yes that looks like it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The behavior of editable installs changed when we transitioned to scikit-build-core, and it affects where the ptx files created during the build can be discovered. Editable installs no longer place built files directly alongside source files. Instead, Python's import machinery is leveraged to add built files to the search path. Since ptx files are not Python files, the loader logic isn't relevant, but we now need to ensure that we always search for the ptx files alongside built artifacts (namely Cython compiled modules) rather than Python source files. I'm guessing that nobody has encountered this yet due to preexisting build artifacts in their source directories.
Checklist