Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRT API Updates #14843

Draft
wants to merge 4 commits into
base: feature/numba-cuda-runtime
Choose a base branch
from

Conversation

brandon-b-miller
Copy link
Contributor

This PR makes a number of changes to the NRT API.

  1. Memory allocations are no longer performed through the global MemSys object. It turns out due to technical limitations we can't call function pointers from a cuda module they weren't compiled in, so we can't have a single global MemSys holding malloc and free wrappers that we can safely access from everywhere the NRT API is used. Instead, the NRT APIs will just call malloc and free directly, rather than TheMSys.malloc(...).

  2. The remainder of the MemSys object (which amounts to the stats counting component) has been changed to be stored as a pointer which can be set by an external function. The caller will have to separately allocate TheMSys and call the setter function before using any NRT APIs that use TheMSys if stats are to be recorded.

  3. This PR adds the set of output functions that are needed to post-process a meminfo-tracked string array into a cudf string column including appropriately dereferencing output strings using the NRT API.

@github-actions github-actions bot added Python Affects Python cuDF API. CMake CMake build issue ci labels Jan 23, 2024
@github-actions github-actions bot removed the ci label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue Python Affects Python cuDF API.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant