Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment-agnostic scripts for running ctests and pytests #14992

Merged
merged 31 commits into from
Feb 26, 2024

Conversation

trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Feb 7, 2024

Description

This PR adds environment-agnostic run_*_{ctests,pytests}.sh scripts, and updates test_*_{cpp,python}.sh to call them.

The test_*_{cpp,python}.sh scripts assume they're running in our CI environment, and they do more than just run the tests.

This PR allows devs and downstream consumers to only run the tests, and skip the unrelated logic in test_*_{cpp,python}.sh.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@trxcllnt trxcllnt requested a review from a team as a code owner February 7, 2024 07:38
@github-actions github-actions bot added the ci label Feb 7, 2024
@trxcllnt trxcllnt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 7, 2024
@bdice
Copy link
Contributor

bdice commented Feb 7, 2024

@trxcllnt Just FYI, there are several PRs across RAPIDS adding --no-tests=error to our ctest invocations. These could conflict. See #14983, rapidsai/build-planning#18.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really helpful, I will definitely be using this feature when reproducing CI workflows (especially if I can get away with a "looser" reproduction for testing something specific). I am guessing this design is meant to make it easier to run tests in devcontainers?

ci/run_cudf_ctests.sh Outdated Show resolved Hide resolved
@trxcllnt
Copy link
Contributor Author

trxcllnt commented Feb 7, 2024

@bdice yes this will help with running tests in devcontainers, but the primary motivation for this PR (and all the other similar ones I filed last night) is to provide a test script we can run in the DLFW/NVAIE builds. The test recipes change so frequently that it's difficult to keep the DLFW tests in sync for all repos.

@github-actions github-actions bot added the conda label Feb 11, 2024
@github-actions github-actions bot removed the conda label Feb 12, 2024
@bdice
Copy link
Contributor

bdice commented Feb 26, 2024

/merge

@rapids-bot rapids-bot bot merged commit e03623a into rapidsai:branch-24.04 Feb 26, 2024
69 checks passed
rapids-bot bot pushed a commit that referenced this pull request Feb 29, 2024
Fixes error introduced in #14992 in `test_cpp_memcheck.sh`
Extra line of parameters removed from the call to `run_cudf_memcheck_ctests.sh`

Authors:
  - David Wendt (https://github.com/davidwendt)
  - https://github.com/jakirkham

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Ray Douglass (https://github.com/raydouglass)

URL: #15158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants