Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the java API so a global default host allocator can be set. #15026

Open
wants to merge 8 commits into
base: branch-24.04
Choose a base branch
from

Conversation

revans2
Copy link
Contributor

@revans2 revans2 commented Feb 12, 2024

Description

Originally the design for host memory limits wanted to give us the ability to do different things for different operations. That changed and now we really just want to set a global allocator instead.

In addition this removed host memory reservations, which was part of the original design, but is no longer needed and would be hard to maintain. It also adds in a Raw allocation API so that we can wrap the original allocation API if needed.

Note that this is a braking change not only because it is removing some unused features but it changes some APIs that some downstream projects are using, which will require the downstream project to have a patch ready to go to avoid breaking.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@revans2 revans2 added 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function breaking Breaking change labels Feb 12, 2024
@revans2 revans2 self-assigned this Feb 12, 2024
@revans2 revans2 requested a review from a team as a code owner February 12, 2024 14:43
Signed-off-by: Robert (Bobby) Evans <bobby@apache.org>
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Copy link
Collaborator

@jbrennan333 jbrennan333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

@vyasr
Copy link
Contributor

vyasr commented May 22, 2024

@revans2 did this stall for any particular reason? Do we want to get this merged?

@revans2
Copy link
Contributor Author

revans2 commented May 23, 2024

@vyasr It stalled because of other priorities, and this is not technically a requirement. I'll probably get back to it once all of the JSON work I am doing is done. If you want me to close it/retarget it to a different release I am happy to do it.

@vyasr
Copy link
Contributor

vyasr commented May 23, 2024

No problem. We can keep it open if you plan to come back to it, and you can retarget it then. I just wanted to clean it up if it should be either merged soon or closed as a wontfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond breaking Breaking change improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants