Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable docs errors. #15265

Merged
merged 4 commits into from
Mar 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ci/build_docs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ rapids-mamba-retry install \

export RAPIDS_DOCS_DIR="$(mktemp -d)"

# TODO: Disable hard errors until the docs site is accessible (network problems)
EXITCODE=0
trap "EXITCODE=1" ERR
set +e

rapids-logger "Build CPP docs"
pushd cpp/doxygen
aws s3 cp s3://rapidsai-docs/librmm/html/${RAPIDS_VERSION_NUMBER}/rmm.tag . || echo "Failed to download rmm Doxygen tag"
Expand Down Expand Up @@ -66,4 +71,11 @@ if [[ "${RAPIDS_BUILD_TYPE}" != "pull-request" ]]; then
fi
popd

rapids-upload-docs
if [[ "${EXITCODE}" == "0" ]]; then
rapids-upload-docs
else
rapids-logger "Docs script had errors resulting in exit code $EXITCODE"
fi

# TODO: Disable hard errors until the docs site is accessible (network problems)
exit 0
7 changes: 5 additions & 2 deletions python/cudf/cudf/core/column/column.py
Original file line number Diff line number Diff line change
Expand Up @@ -975,9 +975,12 @@ def astype(self, dtype: Dtype, copy: bool = False) -> ColumnBase:
# TODO: Figure out why `cudf.dtype("category")`
# astype's different than just the string
return col.as_categorical_column(dtype)
elif dtype == "interval" and isinstance(
self.dtype, cudf.IntervalDtype
elif (
isinstance(dtype, str)
and dtype == "interval"
and isinstance(self.dtype, cudf.IntervalDtype)
):
# astype("interval") (the string only) should no-op
return col
was_object = dtype == object or dtype == np.dtype(object)
dtype = cudf.dtype(dtype)
Expand Down
Loading