Support implicit array conversion with query-planning enabled #15378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzamora
added
bug
wence-
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Makes sense. I suppose there's no need to push upstream because the intent is for this code (afaict from https://github.com/dask/dask-expr/blob/2f5f085511986e51d75caa499e3eab67a8c8b186/dask_expr/_backends.py#L80) to not be long-lived?
Yeah, I'm hoping that the long-term fix for |
rjzamora
added
3 - Ready for Review
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when query-planning is enabled, implicit conversion is not yet supported from a cudf-backed collection to a dask array. Some cuml + dask CI failures are related to this limitation. This PR adds basic support for implicit conversion.
Checklist