Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proxy for inplace operations in cudf.pandas #15695

Merged
merged 13 commits into from
May 8, 2024
Merged

Add proxy for inplace operations in cudf.pandas #15695

merged 13 commits into from
May 8, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #15676

This PR implements __iadd__ and __isub__ methods to allow in-place subtraction and addition operations.

Forks out from #14534

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change cudf.pandas Issues specific to cudf.pandas labels May 7, 2024
@galipremsagar galipremsagar added this to the Proxying - cudf.pandas milestone May 7, 2024
@galipremsagar galipremsagar self-assigned this May 7, 2024
@galipremsagar galipremsagar requested a review from a team as a code owner May 7, 2024 20:19
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 7, 2024
bdice
bdice requested changes May 7, 2024
View reviewed changes
python/cudf/cudf/pandas/fast_slow_proxy.py Outdated Show resolved Hide resolved
python/cudf/cudf/pandas/fast_slow_proxy.py Outdated Show resolved Hide resolved
@bdice bdice mentioned this pull request May 7, 2024
Merged
3 tasks
@galipremsagar galipremsagar requested a review from bdice May 8, 2024 19:30
@galipremsagar
Copy link
Contributor Author

@bdice This PR is now ready for review

bdice
bdice requested changes May 8, 2024
View reviewed changes
python/cudf/cudf_pandas_tests/test_cudf_pandas.py Outdated Show resolved Hide resolved
python/cudf/cudf/pandas/fast_slow_proxy.py Outdated Show resolved Hide resolved
bdice
bdice reviewed May 8, 2024
View reviewed changes
python/cudf/cudf_pandas_tests/test_cudf_pandas.py
"__iadd__",
"__iand__",
"__ifloordiv__",
"__imod__",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__imatmul__ is implemented for Series, so please test that. This test only appears to cover DataFrame.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

galipremsagar and others added 3 commits May 8, 2024 14:48
@galipremsagar @bdice
Update python/cudf/cudf/pandas/fast_slow_proxy.py
985f0e1 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@galipremsagar @bdice
Update python/cudf/cudf_pandas_tests/test_cudf_pandas.py
eb0fc9d 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@galipremsagar
Update test_cudf_pandas.py
831cf11
@galipremsagar galipremsagar requested a review from bdice May 8, 2024 19:52
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 8, 2024
@galipremsagar galipremsagar changed the title Add proxy for __iadd__ and __isub__ in cudf.pandas Add proxy for inplace operations in cudf.pandas May 8, 2024
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit b09e794 into rapidsai:branch-24.06 May 8, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working cudf.pandas Issues specific to cudf.pandas non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
Proxying - cudf.pandas
Development

Successfully merging this pull request may close these issues.

[BUG] __isub__ and __iadd__ implementations are missing in cudf.pandas
2 participants
@galipremsagar @bdice