Refine CudaTest.testCudaException in case throwing wrong type of CudaError under aarch64
#15706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified on my local arm64 rocky8 container, unit tests can PASS! |
NvTimLiu
approved these changes
May 9, 2024
|
/ok to test |
jlowe
reviewed
May 9, 2024
|
/ok to test |
jlowe
approved these changes
May 10, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15705
Replacing
Cuda.memset(Long.MAX_VALUE, (byte) 0, 1024)withCuda.freePinned(-1L), the previous one throws fatal CUDAErrorcudaErrorIllegalAddressinstead of nonFatal CUDAErrorcudaErrorInvalidValueunder aarch64, while the later one throwing the correct kind of error.Enable the test case when Sanitizer is ON