Fix ColumnAccessor caching of nrows if empty previously #15710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
bug
wence-
reviewed
May 10, 2024
Comment on lines
356
to
357
| new_ncols = len(self._data) | ||
| self._clear_cache(old_ncols, new_ncols) |
There was a problem hiding this comment.
I think the invariant is new_ncols == old_ncols + 1? So no need to compute len here.
There was a problem hiding this comment.
Good call. Will swap to this
wence-
requested changes
May 10, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#14758 may have propagated a caching invalidation bug of the number of rows in a
ColumnAccessorPreviously the number of rows was cached and cleared only if an operation caused the
ColumnAccessorto have no more columns.However, if the
ColumnAccessorwas empty and operation added new columns, the cached number of rows should have also been cleared.Checklist