Fix memory size in create_byte_range_infos_consecutive #16012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
mhaseeb123
reviewed
Jun 12, 2024
| @@ -31,7 +31,7 @@ std::vector<byte_range_info> create_byte_range_infos_consecutive(int64_t total_b | |||
| auto range_size = util::div_rounding_up_safe(total_bytes, range_count); | |||
There was a problem hiding this comment.
Minor suggestion: Though not a part of this PR change set but range_size could be made const.
There was a problem hiding this comment.
Nvm, just checked that the return type of div_rounding_up_safe is constexpr anyway so auto should be good!
There was a problem hiding this comment.
The function div_rounding_up_safe is constexpr. AFAIK, constexpr does not apply to return type. Return type is I, here int64_t.
range_size should be int64_t.
mhaseeb123
approved these changes
Jun 12, 2024
karthikeyann
approved these changes
Jun 18, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes over allocated memory for range vector in
cudf::io::text::create_byte_range_infos_consecutiveChecklist