Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFrame.join #33

Merged
merged 28 commits into from
Jul 28, 2017
Merged

DataFrame.join #33

merged 28 commits into from
Jul 28, 2017

Conversation

sklam
Copy link
Contributor

@sklam sklam commented Jul 26, 2017

  • Supports left, inner, right, outer join.
  • Doesn't support on parameter.
  • Doesn't support other that are not a single DataFrame.

@sklam sklam requested a review from seibert July 26, 2017 22:50
@seibert seibert merged commit ac5f304 into rapidsai:master Jul 28, 2017
@sklam sklam deleted the feature/join branch July 28, 2017 19:00
@sklam sklam mentioned this pull request Aug 1, 2017
sklam added a commit to sklam/pygdf that referenced this pull request Jun 11, 2018
kkraus14 pushed a commit that referenced this pull request Oct 21, 2019
Update with nvstrings issue
raydouglass pushed a commit that referenced this pull request Nov 7, 2023
We currently have -main related jobs to build wheels and compare the current PRs pandas tests with branch-23.10-xdf. In these -main jobs, we perform git checkout branch-23.10-xdf, this will actually fetch the latest branch-23.10-xdf from rapidsai/cudf-private, which is most likely to be up-to-date than when the PR's branch has been created. This is causing the pandas test reporting to compare upstream/branch-23.10-xdf diff to the current PR which basically gives us misleading results unless we update the current branch again with upstream/branch-23.10-xdf. Thus to correctly compare just the PR's impact we need to count and revert the number of commits a PR is introducing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants