Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor class structure #54

Merged
merged 27 commits into from
Aug 10, 2017
Merged

Conversation

sklam
Copy link
Contributor

@sklam sklam commented Aug 9, 2017

Refactor for the class restructuring suggestion in #38.

  • The new Column class corresponds to the Data class in the suggestion.
  • GenericIndex now contains Column instead of Series.
  • Column contains data and mask. It implements operation on the container (e.g. append). It does not contain operations that requires logical interpretation of the data type, which is done by subclasses of TypedColumnBase:
    • NumericalColumn implements the operations for numeric data.
    • CategoricalColumn implements the operations for categorical data.

Also includes a lot of clean ups of obsolete code due to new implementation in libgdf:

  • ad-hoc reduction code is removed
  • ad-hoc radixsort code is removed
  • unique_k now reuse components shared with groupby.

@sklam sklam requested a review from seibert August 10, 2017 21:32
@seibert seibert merged commit b43ff58 into rapidsai:master Aug 10, 2017
@sklam sklam mentioned this pull request Aug 22, 2017
@sklam sklam deleted the refactor/seriesimpl branch August 24, 2017 16:18
raydouglass pushed a commit that referenced this pull request Nov 7, 2023
Support iterator data in DataFrame construction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants