-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor class structure #54
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(forgotten to include for previous commit)
(forgotten to include previously)
Update unaryop.
and fixes stats test
# Conflicts: # pygdf/series.py
Replaced with impl in libgdf
Closed
raydouglass
pushed a commit
that referenced
this pull request
Nov 7, 2023
Support iterator data in DataFrame construction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor for the class restructuring suggestion in #38.
Column
class corresponds to theData
class in the suggestion.GenericIndex
now containsColumn
instead ofSeries
.Column
contains data and mask. It implements operation on the container (e.g. append). It does not contain operations that requires logical interpretation of the data type, which is done by subclasses ofTypedColumnBase
:NumericalColumn
implements the operations for numeric data.CategoricalColumn
implements the operations for categorical data.Also includes a lot of clean ups of obsolete code due to new implementation in libgdf: