fixed_point_value double-shifts in fixed_point construction
#6950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codereport
added
bug
4 tasks
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #6950 +/- ##
===============================================
+ Coverage 81.59% 82.03% +0.43%
===============================================
Files 96 96
Lines 15907 16260 +353
===============================================
+ Hits 12980 13339 +359
+ Misses 2927 2921 -6
Continue to review full report at Codecov.
|
davidwendt
approved these changes
Dec 9, 2020
rgsl888prabhu
approved these changes
Dec 9, 2020
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 11, 2020
Currently has changes for #6950 included. The full set of null mask `fixed_point_column_wrapper` constructors aren't supported. This PR adds them all and also adds unit tests for each of them across difference `fixed_point` API tests. **To Do List:** * [x] Add constructors * [x] Add basic unit test * [x] Add all unit tests * [x] Update docs Authors: - Mark Harris <mharris@nvidia.com> - Conor Hoekstra <codereport@outlook.com> Approvers: - null - Vukasin Milovanovic URL: #6951
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug that got merged in #6814. The
fixed_point_valueshould have been using thescaled_integerconstructor. My unit tests didn't catch it because I also used the wrong constructor in the unit tests. Both cases have been fixed (and clean up and missing docs added).