Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JNI support for IDENTITY hash partitioning [skip ci] #7626

Merged
merged 3 commits into from
Mar 17, 2021
Merged

Add JNI support for IDENTITY hash partitioning [skip ci] #7626

merged 3 commits into from
Mar 17, 2021

Conversation

revans2
Copy link
Contributor

@revans2 revans2 commented Mar 17, 2021

This adds in support for identity hash partitioning in JNI.

@revans2 revans2 added 3 - Ready for Review Ready for review by team Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 17, 2021
@revans2 revans2 self-assigned this Mar 17, 2021
@revans2 revans2 requested a review from a team as a code owner March 17, 2021 15:24
@revans2 revans2 added this to PR-WIP in v0.19 Release via automation Mar 17, 2021
v0.19 Release automation moved this from PR-WIP to PR-Reviewer approved Mar 17, 2021
jlowe
jlowe approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small indentation nit but otherwise lgtm.

java/src/main/native/src/TableJni.cpp Outdated Show resolved Hide resolved
@jlowe jlowe added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Mar 17, 2021
@jlowe
Copy link
Member

jlowe commented Mar 17, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0b766c5 into rapidsai:branch-0.19 Mar 17, 2021
v0.19 Release automation moved this from PR-Reviewer approved to Done Mar 17, 2021
@revans2 revans2 deleted the jni_identity_hash_part branch March 17, 2021 15:57
raydouglass added a commit that referenced this pull request Apr 21, 2021
@raydouglass
Merge pull request #7626 from rapidsai/branch-0.19
6573759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees

@revans2 revans2

Labels
3 - Ready for Review Ready for review by team 5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
No open projects
v0.19 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@revans2 @jlowe