Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for writing empty dataframe #8490

Merged
merged 3 commits into from Jun 11, 2021

Conversation

shaneding
Copy link
Contributor

Closes #6691

Removed expectation of table.num_columns() > 0. Instead if table.num_columns() == 0, outputs a line terminator following Pandas behaviour.

@shaneding shaneding requested review from a team as code owners June 10, 2021 21:34
@github-actions github-actions bot added cuDF (Python) Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Jun 10, 2021
@shaneding shaneding added the non-breaking Non-breaking change label Jun 10, 2021
@galipremsagar galipremsagar added the bug Something isn't working label Jun 10, 2021
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python/Cython Approval

@galipremsagar galipremsagar added this to PR-WIP in v21.08 Release via automation Jun 10, 2021
@galipremsagar galipremsagar moved this from PR-WIP to PR-Needs review in v21.08 Release Jun 10, 2021
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

v21.08 Release automation moved this from PR-Needs review to PR-Reviewer approved Jun 11, 2021
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@3fd3624). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8490   +/-   ##
===============================================
  Coverage                ?   82.91%           
===============================================
  Files                   ?      109           
  Lines                   ?    17982           
  Branches                ?        0           
===============================================
  Hits                    ?    14910           
  Misses                  ?     3072           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd3624...917caf9. Read the comment docs.

@shaneding shaneding added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jun 11, 2021
@rgsl888prabhu
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0a4e8a1 into rapidsai:branch-21.08 Jun 11, 2021
v21.08 Release automation moved this from PR-Reviewer approved to Done Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working cuDF (Python) Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[BUG] RuntimeError when empty dataframe is being written to csv file
5 participants