Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessing struct columns from dask_cudf #8675

Merged
merged 9 commits into from Jul 21, 2021
Merged

Accessing struct columns from dask_cudf #8675

merged 9 commits into from Jul 21, 2021

Conversation

shaneding
Copy link
Contributor

Closes #8657

@shaneding shaneding requested a review from a team as a code owner July 7, 2021 18:55
@github-actions github-actions bot added the cuDF (Python) Affects Python cuDF API. label Jul 7, 2021
@shaneding shaneding requested a review from a team as a code owner July 7, 2021 19:10
@codecov
Copy link

codecov bot commented Jul 7, 2021 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@e6ae76e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8675   +/-   ##
===============================================
  Coverage                ?   10.60%           
===============================================
  Files                   ?      116           
  Lines                   ?    19019           
  Branches                ?        0           
===============================================
  Hits                    ?     2017           
  Misses                  ?    17002           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6ae76e...46676cc. Read the comment docs.

@shaneding shaneding added feature request New feature or request non-breaking Non-breaking change labels Jul 7, 2021
beckernick
beckernick previously requested changes Jul 8, 2021
View reviewed changes
Copy link
Member

@beckernick beckernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- glad this was a such a simple solution. A commented out line of code in the test

python/dask_cudf/dask_cudf/tests/test_struct.py Outdated Show resolved Hide resolved
@caryr35 caryr35 added this to PR-WIP in v21.08 Release via automation Jul 8, 2021
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v21.08 Release Jul 8, 2021
isVoid
isVoid reviewed Jul 9, 2021
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
@shaneding
Copy link
Contributor Author

Blocked by #8718, merge after.

@galipremsagar
Copy link
Contributor

rerun tests
rerun tests

@shaneding shaneding added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Jul 20, 2021
@shaneding
Copy link
Contributor Author

Still some issue when the dataframe is partitioned, looking into this now.

@shaneding
Copy link
Contributor Author

Depends on #8811

@galipremsagar
Copy link
Contributor

rerun tests

@shaneding shaneding removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Jul 21, 2021
@galipremsagar galipremsagar dismissed beckernick’s stale review July 21, 2021 21:39

Change requested was addressed and since Nick is OOTO unblocking to merge this PR

v21.08 Release automation moved this from PR-Needs review to PR-Reviewer approved Jul 21, 2021
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jul 21, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d462756 into rapidsai:branch-21.08 Jul 21, 2021
v21.08 Release automation moved this from PR-Reviewer approved to Done Jul 21, 2021
@sarahyurick sarahyurick mentioned this pull request Jul 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid left review comments

@galipremsagar galipremsagar galipremsagar approved these changes

@rjzamora rjzamora rjzamora approved these changes

@beckernick beckernick beckernick left review comments

@skirui-source skirui-source Awaiting requested review from skirui-source

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge cuDF (Python) Affects Python cuDF API. feature request New feature or request non-breaking Non-breaking change
Projects
No open projects
v21.08 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Cannot select struct typed columns in Dask cuDF
5 participants
@shaneding @galipremsagar @beckernick @isVoid @rjzamora