Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix typo in the name of cudf-testing-targets.cmake #9190

Conversation

trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Sep 7, 2021

This fix enables local source builds using the build directory as cudf_ROOT to find cudf::cudftestutil targets again.

@trxcllnt trxcllnt requested a review from a team as a code owner September 7, 2021 22:58
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Sep 7, 2021
@trxcllnt trxcllnt added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 7, 2021
@caryr35 caryr35 added this to PR-WIP in v21.10 Release via automation Sep 8, 2021
@caryr35 caryr35 moved this from PR-WIP to PR-Reviewer approved in v21.10 Release Sep 8, 2021
@vyasr
Copy link
Contributor

vyasr commented Sep 8, 2021

rerun tests

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@be858a7). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head e81f0f8 differs from pull request most recent head e0ef1b1. Consider uploading reports for the commit e0ef1b1 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #9190   +/-   ##
===============================================
  Coverage                ?   10.77%           
===============================================
  Files                   ?      115           
  Lines                   ?    19138           
  Branches                ?        0           
===============================================
  Hits                    ?     2062           
  Misses                  ?    17076           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be858a7...e0ef1b1. Read the comment docs.

@vyasr
Copy link
Contributor

vyasr commented Sep 8, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 42a70f3 into rapidsai:branch-21.10 Sep 8, 2021
v21.10 Release automation moved this from PR-Reviewer approved to Done Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants