Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ascending parameter for dask-cudf sort_values #9250

Merged
merged 3 commits into from Oct 13, 2021
Merged

Add ascending parameter for dask-cudf sort_values #9250

merged 3 commits into from Oct 13, 2021

Conversation

charlesbluca
Copy link
Member

Closes #9158

Adds support for descending sort in dask-cudf's sort_values, which should open up the use cases for it in dask-contrib/dask-sql#229.

@charlesbluca charlesbluca added feature request New feature or request 3 - Ready for Review Ready for review by team dask-cudf non-breaking Non-breaking change labels Sep 20, 2021
@charlesbluca charlesbluca requested a review from a team as a code owner September 20, 2021 13:54
@charlesbluca charlesbluca added this to PR-WIP in v21.12 Release via automation Sep 20, 2021
@github-actions github-actions bot added the cuDF (Python) Affects Python cuDF API. label Sep 20, 2021
@charlesbluca
Copy link
Member Author

rerun tests

@codecov
Copy link

codecov bot commented Sep 20, 2021 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@40a3b03). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #9250   +/-   ##
===============================================
  Coverage                ?   10.87%           
===============================================
  Files                   ?      115           
  Lines                   ?    19153           
  Branches                ?        0           
===============================================
  Hits                    ?     2082           
  Misses                  ?    17071           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40a3b03...a6b40e5. Read the comment docs.

@charlesbluca charlesbluca linked an issue Sep 21, 2021 that may be closed by this pull request
[FEA] ascending parameter for dask_cudf.DataFrame.sort_values #9158
Closed
@charlesbluca charlesbluca mentioned this pull request Sep 23, 2021
Closed
v21.12 Release automation moved this from PR-WIP to PR-Reviewer approved Oct 13, 2021
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Oct 13, 2021
@galipremsagar
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cff71ff into rapidsai:branch-21.12 Oct 13, 2021
v21.12 Release automation moved this from PR-Reviewer approved to Done Oct 13, 2021
@charlesbluca charlesbluca deleted the dask-descending-sort branch July 19, 2022 14:26
@vyasr vyasr added dask Dask issue and removed dask-cudf labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

Assignees

@charlesbluca charlesbluca

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge cuDF (Python) Affects Python cuDF API. dask Dask issue feature request New feature or request non-breaking Non-breaking change
Projects
No open projects
v21.12 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] ascending parameter for dask_cudf.DataFrame.sort_values
3 participants
@charlesbluca @galipremsagar @vyasr