Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Clang Version to 11.0.0 #1688

Merged
merged 13 commits into from Jul 7, 2021
Merged

Updating Clang Version to 11.0.0 #1688

merged 13 commits into from Jul 7, 2021

Conversation

codereport
Copy link
Contributor

@codereport codereport commented Jun 25, 2021 •
edited

Follow up PR to: rapidsai/cudf#6695. Performing the same changes but for rapidsai/cugraph

Depends on: rapidsai/integration#304

@codereport codereport requested review from a team as code owners June 25, 2021 22:21
@codereport codereport mentioned this pull request Jun 28, 2021
Merged
dillon-cullinan
dillon-cullinan suggested changes Jun 28, 2021
View reviewed changes
ci/checks/style.sh Outdated Show resolved Hide resolved
@BradReesWork BradReesWork added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 28, 2021
@BradReesWork BradReesWork added this to the 21.08 milestone Jun 28, 2021
@BradReesWork
Copy link
Member

@codereport there are some style issues that need to be fixed

@ChuckHastings
Copy link
Collaborator

The fundamental issue with the style checker is that a number of files were updated for format (the clang format rules changed) but the copyright dates weren't updated to reflect that the contents of the files were changed.

@codereport
Copy link
Contributor Author

rerun tests

1 similar comment
@codereport
Copy link
Contributor Author

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2021 •
edited

Codecov Report

Merging #1688 (6e71972) into branch-21.08 (1778d43) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 6e71972 differs from pull request most recent head ac62459. Consider uploading reports for the commit ac62459 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.08    #1688      +/-   ##
================================================
+ Coverage         59.31%   59.34%   +0.02%     
================================================
  Files                80       80              
  Lines              3557     3559       +2     
================================================
+ Hits               2110     2112       +2     
  Misses             1447     1447
Impacted Files Coverage Δ
python/cugraph/_version.py 44.80% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1778d43...ac62459. Read the comment docs.

@codereport
Copy link
Contributor Author

@gpucibot merge

1 similar comment
@ajschmidt8
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e2ac467 into rapidsai:branch-21.08 Jul 7, 2021
v21.08 Release automation moved this from PRs to Done Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@dillon-cullinan dillon-cullinan dillon-cullinan approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v21.08 Release
  
Done
Milestone
21.08
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@codereport @BradReesWork @ChuckHastings @codecov-commenter @ajschmidt8 @dillon-cullinan