Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] updating notebooks #1761

Merged
merged 6 commits into from Aug 9, 2021
Merged

[REVIEW] updating notebooks #1761

merged 6 commits into from Aug 9, 2021

Conversation

BradReesWork
Copy link
Member

updating notebooks

@BradReesWork BradReesWork requested a review from a team as a code owner August 5, 2021 18:31
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 5, 2021
@BradReesWork BradReesWork added this to the 21.10 milestone Aug 5, 2021
@BradReesWork BradReesWork added this to PRs in 21.10 Release Aug 5, 2021
@BradReesWork BradReesWork linked an issue Aug 5, 2021 that may be closed by this pull request
[ENH] Pagerank notebook should show a personalization example #1569
Closed
@BradReesWork BradReesWork changed the title [WIP] updating notebooks [REVIEW] updating notebooks Aug 5, 2021
@BradReesWork BradReesWork self-assigned this Aug 5, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2021 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@f1dffc4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #1761   +/-   ##
===============================================
  Coverage                ?   59.75%           
===============================================
  Files                   ?       77           
  Lines                   ?     3523           
  Branches                ?        0           
===============================================
  Hits                    ?     2105           
  Misses                  ?     1418           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1dffc4...9d585a8. Read the comment docs.

@BradReesWork
Copy link
Member Author

rerun tests

This was linked to issues Aug 6, 2021
[FIX] Katz centrality test on asymmetric directed graph produces different results than NetX #1042
Closed
[BUG] Managed memory hangs #1635
Closed
@BradReesWork BradReesWork requested a review from a team as a code owner August 6, 2021 16:08
rlratzel
rlratzel approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor typo, no need to hold up approval.

notebooks/community/Louvain.ipynb Outdated Show resolved Hide resolved
@BradReesWork @rlratzel
Update notebooks/community/Louvain.ipynb
9d585a8 
Co-authored-by: Rick Ratzel <3039903+rlratzel@users.noreply.github.com>
@BradReesWork
Copy link
Member Author

@gpucibot merge

1 similar comment
@BradReesWork
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 341b9b0 into rapidsai:branch-21.10 Aug 9, 2021
21.10 Release automation moved this from PRs to Done Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

@jnke2016 jnke2016 Awaiting requested review from jnke2016

Assignees

@BradReesWork BradReesWork

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
21.10 Release
  
Done
Milestone
21.10
3 participants
@BradReesWork @codecov-commenter @rlratzel