Move experimental source files and a few implementation headers #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
3 - Ready for Review
improvement
seunghwak
approved these changes
Aug 6, 2021
cpp/tests/CMakeLists.txt
Outdated
|
|
||
| ################################################################################################### | ||
| # - Experimental PAGERANK tests ------------------------------------------------------------------- | ||
| ConfigureTest(EXPERIMENTAL_PAGERANK_TEST experimental/pagerank_test.cpp) | ||
| ConfigureTest(PAGERANK_TEST pagerank/pagerank_test.cpp) |
There was a problem hiding this comment.
To be consistent with python, shouldn't this better go to link_analysis (after creating the directory)?
There was a problem hiding this comment.
Except I disagree with that python choice :-)
I'll make that change.
There was a problem hiding this comment.
The src directory also uses link_analysis. Now src, tests and python all match.
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #1763 +/- ##
===============================================
Coverage ? 59.72%
===============================================
Files ? 77
Lines ? 3521
Branches ? 0
===============================================
Hits ? 2103
Misses ? 1418
Partials ? 0 Continue to review full report at Codecov.
|
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last phase of migrating things out of the experimental namespace. This PR moves all of the source and test files out of the experimental directory and renames the tests.