Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary workaround for CI issues with 11.0 #1883

Merged

Conversation

ChuckHastings
Copy link
Collaborator

#1870 disabled some tests to allow us to push some things through CI. While investigating this issue we discovered that we are having problem compiling the code in a container that uses the delivered 11.0 thrust.

This PR is a different temporary workaround. We force downloading the desired version of thrust to be used as part of the cugraph build. The PR also reactivates all of the WCC testing.

@ChuckHastings ChuckHastings requested review from a team as code owners October 14, 2021 16:04
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ChuckHastings ChuckHastings self-assigned this Oct 14, 2021
@ChuckHastings ChuckHastings added this to the 21.12 milestone Oct 14, 2021
@ChuckHastings ChuckHastings added the bug Something isn't working label Oct 14, 2021
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake changes LGTM

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@af1a953). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #1883   +/-   ##
===============================================
  Coverage                ?   70.08%           
===============================================
  Files                   ?      143           
  Lines                   ?     8817           
  Branches                ?        0           
===============================================
  Hits                    ?     6179           
  Misses                  ?     2638           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af1a953...52383c7. Read the comment docs.

@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit de4466d into rapidsai:branch-21.12 Oct 14, 2021
21.12 Release automation moved this from PRs to Done Oct 14, 2021
@ChuckHastings ChuckHastings deleted the bug_cuda_11_0_workaround branch February 1, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
No open projects
21.12 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants