Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi gpu sample edges utilities #2064

Merged
merged 18 commits into from
Feb 16, 2022
Merged

Conversation

kaatish
Copy link
Collaborator

@kaatish kaatish commented Feb 8, 2022

Add utilities to enable multi gpu gathering to be used for mnmg sampling.

@kaatish kaatish requested review from a team as code owners February 8, 2022 14:47
@kaatish kaatish changed the title Sample edges utilities Multi gpu sample edges utilities Feb 8, 2022
@kaatish kaatish added the non-breaking Non-breaking change label Feb 8, 2022
@kaatish kaatish added the feature request New feature or request label Feb 8, 2022
@kaatish kaatish added this to the 22.04 milestone Feb 8, 2022
@kaatish kaatish self-assigned this Feb 8, 2022
@ChuckHastings ChuckHastings added this to PRs in 22.04 Release Feb 8, 2022
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@42eaf3c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #2064   +/-   ##
===============================================
  Coverage                ?   73.55%           
===============================================
  Files                   ?      156           
  Lines                   ?    10295           
  Branches                ?        0           
===============================================
  Hits                    ?     7573           
  Misses                  ?     2722           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42eaf3c...6ce98ba. Read the comment docs.

Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More review comments are coming.

cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
rmm::device_uvector<gpu_t>& active_source_gpu_ids,
EdgeIndexIterator edge_index_first,
typename GraphViewType::vertex_type invalid_vertex_id,
int indices_per_source,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better be size_t instead of int

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed it to edge type. We do not expect this value to exceed the maximum vertex degree.

cpp/src/structure/graph_impl.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
adjacency_list_offsets.reserve(graph_view.get_number_of_local_adj_matrix_partitions());
adjacency_list_indices.reserve(graph_view.get_number_of_local_adj_matrix_partitions());

id_segments.push_back(0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can compute id_segments using get_vertex_partition_lasts() (https://github.com/rapidsai/cugraph/blob/branch-22.04/cpp/include/cugraph/graph_view.hpp#L115).

cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More reviews coming.

cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
cpp/include/cugraph/prims/gather_edges.cuh Outdated Show resolved Hide resolved
@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f6a92fc into rapidsai:branch-22.04 Feb 16, 2022
22.04 Release automation moved this from PRs to Done Feb 16, 2022
rapids-bot bot pushed a commit that referenced this pull request Mar 17, 2022
This PR tracks work on MNMG Neighborhood Sampling, for G(C)NN needs.

Dependencies:
1. #1982
2. #2064
3. Integration of rapidsai/cugraph-ops#24 into `cugraph`

Authors:
  - Andrei Schaffer (https://github.com/aschaffer)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)
  - Kumar Aatish (https://github.com/kaatish)
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #2073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
No open projects
22.04 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants