Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Katz Centrality to pylibcugraph, refactor Katz Centrality for cugraph #2201

Merged
merged 29 commits into from Apr 20, 2022

Conversation

betochimas
Copy link
Contributor

This PR adds Single-GPU (SG) Katz Centrality to the pylibcugraph software stack, as well as refactoring SG Katz Centrality for the cugraph software stack. Both Katz Centrality algorithms are wrappers calling a lower level version of the algorithm, originally based on the C API. This PR directly depends on #2192, and combined with it, should close #1759.

@betochimas betochimas added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #2201 (65949e3) into branch-22.06 (b8a6c60) will increase coverage by 0.51%.
The diff coverage is 92.63%.

@@               Coverage Diff                @@
##           branch-22.06    #2201      +/-   ##
================================================
+ Coverage         70.82%   71.33%   +0.51%     
================================================
  Files               170      171       +1     
  Lines             11036    11161     +125     
================================================
+ Hits               7816     7962     +146     
+ Misses             3220     3199      -21     
Impacted Files Coverage Δ
python/cugraph/cugraph/centrality/__init__.py 100.00% <ø> (ø)
...thon/cugraph/cugraph/centrality/katz_centrality.py 87.75% <85.71%> (-1.72%) ⬇️
...cugraph/pylibcugraph/tests/test_katz_centrality.py 94.44% <94.44%> (ø)
...thon/cugraph/cugraph/tests/test_katz_centrality.py 98.94% <100.00%> (-1.06%) ⬇️
...pylibcugraph/pylibcugraph/experimental/__init__.py 100.00% <100.00%> (ø)
python/cugraph/cugraph/tests/dask/test_mg_bfs.py 0.00% <0.00%> (ø)
python/cugraph/cugraph/tests/dask/test_mg_hits.py 0.00% <0.00%> (ø)
python/cugraph/cugraph/tests/dask/test_mg_sssp.py 0.00% <0.00%> (ø)
python/cugraph/cugraph/tests/dask/test_mg_comms.py 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8a6c60...65949e3. Read the comment docs.

@BradReesWork BradReesWork added this to the 22.06 milestone Apr 7, 2022
@BradReesWork BradReesWork added this to PRs in 22.06 Release Apr 7, 2022
@betochimas betochimas marked this pull request as ready for review April 14, 2022 15:45
@betochimas betochimas requested review from a team as code owners April 14, 2022 15:45
@betochimas betochimas added breaking Breaking change and removed non-breaking Non-breaking change labels Apr 19, 2022
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3c4cd18 into rapidsai:branch-22.06 Apr 20, 2022
22.06 Release automation moved this from PRs to Done Apr 20, 2022
rapids-bot bot pushed a commit that referenced this pull request Apr 27, 2022
This PR is a slight reversion of a minor change from #2201, which changed the signature for the refactored SG Katz method in cugraph. That PR was breaking, but when combined with this one, will be non-breaking for the next release. This closes #1759 (already closed).

Authors:
  - https://github.com/betochimas

Approvers:
  - Rick Ratzel (https://github.com/rlratzel)

URL: #2242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function
Projects
No open projects
22.06 Release
  
Done
Development

Successfully merging this pull request may close these issues.

[ENH] SG python implementation of katz_centrality still uses legacy.
5 participants