-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Datasets API to Update Notebook Examples #2440
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…to datasets-api-nb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I had one minor suggestion and an observation which need not hold up approval.
"metadata": {}, | ||
"outputs": [], | ||
"source": [ | ||
"# You can also just get the edgelist\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just remove this comment since it's probably not needed, and it sounds a little less formal that the others anyway.
"G = karate.get_graph()\n", | ||
"G = G.to_undirected()" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is perhaps out-of-scope for this PR, but it would be nice if get_graph
accepted a create_using
option similar to cugraph.from_edgelist
that allowed you to get a directed or undirected graph.
rerun tests |
@gpucibot merge |
@gpucibot merge |
Addresses issue #2364
All of the SG notebook examples have been updated to use the newly added Datasets API. Previously, Graph objects were created by specifying a path to the
.csv
file, callingcuDF
to read in the file, and then converting the edge list to a graph.Now, a dataset object is imported and can create graphs by calling the
get_graph()
method. Comments and headings have also been updated for continuity.