Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update raft import #2729

Merged

Conversation

jnke2016
Copy link
Contributor

This PR updates the way raft is imported following changes on the raft new conda packages.

closes #2727

@jnke2016 jnke2016 requested review from a team as code owners September 24, 2022 01:36
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@238f909). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.10    #2729   +/-   ##
===============================================
  Coverage                ?   60.04%           
===============================================
  Files                   ?      111           
  Lines                   ?     6184           
  Branches                ?        0           
===============================================
  Hits                    ?     3713           
  Misses                  ?     2471           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 24, 2022
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. I also added @cjnolet just to make sure this is the new intended import.

@rlratzel
Copy link
Contributor

rerun tests

reason: build timed out. Timeouts should be less common after #2707 is merged, but trying a rerun now anyway.

@alexbarghi-nv
Copy link
Member

rerun tests

@jjacobelli jjacobelli removed the request for review from a team September 27, 2022 07:24
@jjacobelli
Copy link
Contributor

Removing ops-codeowners from the required reviews since it doesn't seem there are any file changes that we're responsible for. Feel free to add us back if necessary.

@rlratzel
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c2f983f into rapidsai:branch-22.10 Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Raft import changed
6 participants