Use new sampling primitives #2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
2 - In Progress
improvement
…ing yet, still need to test RW
ChuckHastings
changed the title
BradReesWork
requested review from
seunghwak,
naimnv,
jnke2016 and
robertmaynard
seunghwak
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
Looks like a big improvement in simplifying our code to support neighbor sampling and random walks.
I feel like we can delete many more detail space sampling related files and further simplify the codebase, but I guess we can revisit this in the next release.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #2751 +/- ##
===============================================
Coverage ? 59.77%
===============================================
Files ? 111
Lines ? 6160
Branches ? 0
===============================================
Hits ? 3682
Misses ? 2478
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@gpucibot merge |
naimnv
approved these changes
Oct 3, 2022
7 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 11, 2022
This PR fixes the below errors that have popped up in MNMG testing. - [x] fix_out of index keys on MNMG graphs - [x] fix loc/get_node_storage error on MNMG graphs (Work around rapidsai/cudf#11877) - [x] Clear Cached Properties when they become invalid - [x] Remove 6 pytest skipping as both these PRs have landed - #2751 - #2523 - [x] Change `vertex_col_names` to `node_col_names` to match DGL - [x] Ensure MNMG tests pass - [x] Work around the PG bug and also prevent redundant conversion to lists Authors: - Vibhu Jawa (https://github.com/VibhuJawa) Approvers: - Rick Ratzel (https://github.com/rlratzel) - Erik Welch (https://github.com/eriknw) URL: #2786
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2581
Closes #2582
Closes #2665
Update the neighborhood sampling algorithm to use the new neighborhood sampling primitive defined in #2703