Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cugraph-Service Remote Graphs and Algorithm Dispatch #2832

Merged
merged 62 commits into from
Nov 10, 2022

Conversation

alexbarghi-nv
Copy link
Member

@alexbarghi-nv alexbarghi-nv commented Oct 20, 2022

Resolves https://github.com/rapidsai/graph_dl/issues/80

This PR combines RemoteGraph and RemotePropertyGraph, adds support for remote API calls to cugraph.Graph, adds subgraph extraction to the property graph wrappers, adds the ability to dispatch cuGraph algorithms (though currently only uniform_neighbor_sample is supported), better supports multigraphs for subgraph extraction, properly handles renumbering on the server, and supports implicit subgraph extraction for remote graphs.

@alexbarghi-nv alexbarghi-nv self-assigned this Oct 20, 2022
@alexbarghi-nv alexbarghi-nv added feature request New feature or request non-breaking Non-breaking change labels Oct 20, 2022
@alexbarghi-nv alexbarghi-nv added this to the 22.12 milestone Oct 20, 2022
@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review November 2, 2022 19:54
@alexbarghi-nv alexbarghi-nv requested a review from a team as a code owner November 2, 2022 19:54
@BradReesWork
Copy link
Member

rerun tests

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I like how the consolidation of G and PG is happening in RemoteGraph. I just had a few comments/questions.

Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have requested changes around dask stuff looks good other-wise .

Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM .

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ffa4a6d into rapidsai:branch-22.12 Nov 10, 2022
rapids-bot bot pushed a commit that referenced this pull request Nov 17, 2022
Fixes the currently-broken `pyg_hetero_mag` notebook, which fails due to the sampling output not matching what the API expects.  Note: this does use an optional import of PyG, similar to how other code optionally uses `torch` or `cudf`.

Also adds an in-place `fillna` function for `PropertyGraph` and `MGPropertyGraph`.  There is a separate issue to do this for `RemoteGraph` (rapidsai/graph_dl#97).

Also removes an unintended dependence on `cugraph` by adding `is_multi_gpu()` methods to `PropertyGraph` and `MGPropertyGraph` so whether a graph is MG can be determined without importing `cugraph`.

Closes rapidsai/graph_dl#78
Closes rapidsai/graph_dl#77
Closes rapidsai/graph_dl#63

Merge after #2832

Authors:
  - Alex Barghi (https://github.com/alexbarghi-nv)
  - Erik Welch (https://github.com/eriknw)

Approvers:
  - Rick Ratzel (https://github.com/rlratzel)
  - Erik Welch (https://github.com/eriknw)

URL: #2860
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants