Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dask-cuda version and disable wheel builds in CI #3009

Merged
merged 3 commits into from
Dec 1, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 30, 2022

We need to install dask-cuda from source during wheel builds for cugraph CI to pass because dask evolves too fast to pin. We also don't want to build wheels on every PR, so we'll need that disabled. I'll make that change once I confirm that wheel builds pass tests here.

This PR also fixes an unrelated issue causing doctests to fail. I'm guessing that because the docstring is in tests/mg it isn't being discovered during conda gpuCI because we exclude that directory from the pytest command in ci/test.sh.

@vyasr vyasr added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 30, 2022
@vyasr vyasr added this to the 22.12 milestone Nov 30, 2022
@vyasr vyasr self-assigned this Nov 30, 2022
@vyasr vyasr marked this pull request as ready for review December 1, 2022 01:51
@vyasr vyasr requested review from a team as code owners December 1, 2022 01:51
@vyasr vyasr added the DO NOT MERGE Hold off on merging; see PR for details label Dec 1, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Dec 1, 2022

Once the full suite of tests passes with the proper dask-cuda pinning I'll disable the wheels CI and this PR can be merged.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.12@cb0d092). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.12    #3009   +/-   ##
===============================================
  Coverage                ?   58.80%           
===============================================
  Files                   ?      131           
  Lines                   ?     7836           
  Branches                ?        0           
===============================================
  Hits                    ?     4608           
  Misses                  ?     3228           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vyasr vyasr removed the DO NOT MERGE Hold off on merging; see PR for details label Dec 1, 2022
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3a14275 into rapidsai:branch-22.12 Dec 1, 2022
@vyasr vyasr deleted the fix/dask_cuda_wheel_version branch December 1, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
22.12 Release
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

4 participants