Adds initial cugraph-service client scaling benchmark, refactorings, performance config updates #3087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re_params_product() function to PLC.
…2-initial_service_benchmarks
…est to use specific set of input param combinations.
…uniform_neighbor_sampling options
… parameter for with_replacement.
…2-initial_service_benchmarks
…2-initial_service_benchmarks
…fo(), added tests to verify new meta-data is correct.
… with the server, added tests which use/test the new builtin test extensions.
…s (via rapids-pytest-benchmark plugin) easier to read, changes to allow RemoteGraph to use either a server-side Graph or PropertyGraph.
…r LocalCUDACluster for MG service, re-wrote start list generation to work with both SG and MG, added server extension for generating start list, changed scale from 24 to 23 to prevent OOM, added separate function for creating MG graphs, added debug print to show result sizes, fixes to cugraph MG Graph for incorrect column names, added util to cugraph for starting and stopping dask client.
…2-initial_service_benchmarks
…2-initial_service_benchmarks
…chmarks for different libraries.
…ir to pytest-based to avoid name conflict.
… can be more easily shared, bug fix in benchmark extension testing util.
…params, removed funcs unused in each file.
…arkers to pytest.ini, added pythonpath and test paths to pytest.ini, gave benchmark files unique names so pytest can collect them across different bench dirs.
…ception handler for loading extensions, run server from a temp dir to avoid collisions with 'cugraph' namespace package in benchmarks dir.
…2-initial_benchmark_reorg
…, added markers for each batch size.
…efactored utils to include function to conditionally start server if one is not running, added new markers for number of clients.
…2-cgs_client_scaling_benchmarks
…event warmup from hiding time waiting for server, dask-realted perf improvements (from VibhuJawa)
…2-cgs_client_scaling_benchmarks
benchmarks/cugraph/pytest-based/bench_cugraph_uniform_neighbor_sample.py
Outdated
Show resolved
Hide resolved
benchmarks/cugraph/pytest-based/bench_cugraph_uniform_neighbor_sample.py
Outdated
Show resolved
Hide resolved
…2-cgs_client_scaling_benchmarks
…2-cgs_client_scaling_benchmarks
…e those may fail in CI environments (need a separate PR to fix), changes the technique to get the start vertex list to get n random samples from the src vertex list.
…2-cgs_client_scaling_benchmarks
VibhuJawa
suggested changes
Jan 5, 2023
python/cugraph-service/server/cugraph_service_server/__main__.py
Outdated
Show resolved
Hide resolved
python/cugraph-service/server/cugraph_service_server/__init__.py
Outdated
Show resolved
Hide resolved
python/cugraph-service/server/cugraph_service_server/__init__.py
Outdated
Show resolved
Hide resolved
VibhuJawa
reviewed
Jan 5, 2023
python/cugraph-service/server/cugraph_service_server/cugraph_handler.py
Outdated
Show resolved
Hide resolved
…fusion, fixed test errors
|
/merge |
|
rerun tests |
1 similar comment
|
rerun tests |
|
Current Failures are from following: pytest --capture=no --verbose -m "managedmem_on and poolallocator_on and tiny" --benchmark-disable cugraph/pytest-based/bench_algos.py
FAILED: 1 or more tests in cugraph benchmarks |
…2-cgs_client_scaling_benchmarks
jnke2016
reviewed
Jan 11, 2023
benchmarks/cugraph/pytest-based/bench_cugraph_uniform_neighbor_sample.py
Outdated
Show resolved
Hide resolved
jnke2016
reviewed
Jan 11, 2023
benchmarks/cugraph/pytest-based/bench_cugraph_uniform_neighbor_sample.py
Outdated
Show resolved
Hide resolved
…2-cgs_client_scaling_benchmarks
|
rerun tests |
…2-cgs_client_scaling_benchmarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3109