Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves conflicts from forward-merging branch-23.12 into branch-24.02 #4020

Merged
merged 10 commits into from Nov 27, 2023

Conversation

rlratzel
Copy link
Contributor

Resolves forward merge conflicts in #4018

jnke2016 and others added 7 commits November 21, 2023 01:44
Updating the C API graph creation functions to support the following:
* Add support for isolated vertices
* Add MG optimization to support multiple device arrays per rank as input and concatenate them internally
* Add MG optimization to internally compute the number of edges via allreduce rather than requiring it as an input parameter (this can be expensive to compute in python)

This PR implements these features.  Some simple tests exist to check for isolate vertices (by running pagerank which generates a different result if the graph has isolated vertices).  A simple test for multiple input arrays exists for the MG case.

Closes rapidsai#3947 
Closes rapidsai#3974

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Naim (https://github.com/naimnv)

Approvers:
  - Naim (https://github.com/naimnv)
  - Joseph Nke (https://github.com/jnke2016)
  - Seunghwa Kang (https://github.com/seunghwak)

URL: rapidsai#3982
adding C and C++ API 
Adding WholeGraph APIs
Adding cugraph-ops APIs

closes rapidsai#3406

Authors:
  - Brad Rees (https://github.com/BradReesWork)
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Ralph Liu (https://github.com/nv-rliu)
  - Don Acosta (https://github.com/acostadon)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)
  - Don Acosta (https://github.com/acostadon)
  - Rick Ratzel (https://github.com/rlratzel)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: rapidsai#3938
I'm new to CuGraph repository and would like to contribute further in the future. So I start with minor tasks with docs to familiarize myself with the contribution process in this repository.

Here is what I have done in this PR:
- Fixed some invalid links in the documentation.
- Corrected and added formulas related to centrality.
- Added more references to the centrality to ensure consistency.

Also, the images located at https://github.com/rapidsai/cugraph/tree/main/python/cugraph cannot be displayed because it is symbolic link to the repository's README file. But it's not a major issue.

Authors:
  - Huiyu Xie (https://github.com/huiyuxie)
  - Ralph Liu (https://github.com/nv-rliu)
  - Naim (https://github.com/naimnv)
  - Brad Rees (https://github.com/BradReesWork)

Approvers:
  - Don Acosta (https://github.com/acostadon)
  - Brad Rees (https://github.com/BradReesWork)

URL: rapidsai#4002
…`pagerank` (rapidsai#3968)

Add `eigenvector_centrality`, `katz_centrality`, and `hits`. I may add pagerank next.

Authors:
  - Erik Welch (https://github.com/eriknw)
  - Ralph Liu (https://github.com/nv-rliu)
  - Naim (https://github.com/naimnv)
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Rick Ratzel (https://github.com/rlratzel)

URL: rapidsai#3968
@rlratzel rlratzel requested review from a team as code owners November 26, 2023 23:51
Copy link

copy-pr-bot bot commented Nov 26, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 26, 2023
@rlratzel
Copy link
Contributor Author

/ok to test

jnke2016 and others added 2 commits November 27, 2023 03:24
…apidsai#3941)

This PR includes changes that moves some of the MG graph etl steps (such as computing number of edges) to libcugraph to reduce the amount of dask overhead involved in graph creation. Those ETL steps were also responsible for various dask-related transient errors that caused us to temporarily disable MG testing in CI.  These changes allow us to re-enable MG testing in CI, so this PR includes that update too.

Authors:
  - Joseph Nke (https://github.com/jnke2016)
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Naim (https://github.com/naimnv)
  - Vibhu Jawa (https://github.com/VibhuJawa)
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Rick Ratzel (https://github.com/rlratzel)

URL: rapidsai#3941
@rlratzel

This comment was marked as duplicate.

@rlratzel

This comment was marked as duplicate.

@AyodeAwe AyodeAwe merged commit 5d4bcce into rapidsai:branch-24.02 Nov 27, 2023
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants