remove thriftpy2 ceiling #4521
Merged
remove thriftpy2 ceiling #4521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
|
|
bdice
approved these changes
Jul 8, 2024
nv-rliu
approved these changes
Jul 9, 2024
rlratzel
approved these changes
Jul 19, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4496 introduced a ceiling on
thriftpy2. Context: #4496 (comment)The bug that ceiling was added to avoid was fixed in v0.5.2 of
thriftpy2, which was just released (#4478 (comment)).This removes that, adding
!=constraints to skip the 2 versions thatcugraphwas not compatible with.Notes for Reviewers
Why not a floor?
I'm proposing adding
!=constraints to skip v0.5.0 and v0.5.1 to maximizecugraph's compatibility with other environments... that'd allow it to be used in environments withthriftpy2<0.5.0and in environments withthriftpy2>0.5.2.Let me know if you'd prefer the simplicity of a floor like
>=0.5.2instead.