Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Pre and post processing of labels for Random Forest wrapper #691

Closed
Salonijain27 opened this issue Jun 15, 2019 · 2 comments · Fixed by #4780
Closed

[FEA] Pre and post processing of labels for Random Forest wrapper #691

Salonijain27 opened this issue Jun 15, 2019 · 2 comments · Fixed by #4780
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
v22.10 Release

Comments

@Salonijain27
Copy link
Contributor

Functions for pre and post processing of labels need to be added in the cython wrapper for Random Forest Classification
@Salonijain27 Salonijain27 added ? - Needs Triage Need team to review and classify feature request New feature or request labels Jun 15, 2019
@Salonijain27 Salonijain27 changed the title [FEA] Pre and post processing of labels for Random Forest [FEA] Pre and post processing of labels for Random Forest wrapper Jun 15, 2019
@myrtw
Copy link
Contributor

myrtw commented Jun 17, 2019

Simply noting that this feature is necessary for Random Forest classification for datasets where labels do not meet the "labels should be contiguous numbers from 0 to number of unique labels" requirement.

@teju85
Copy link
Member

teju85 commented Jun 17, 2019

There's a make_monotonic ml-prim implemented by @cjnolet. That should be enough here, I think.

@cjnolet cjnolet added this to Issue-Needs prioritizing in v0.9 Release via automation Jun 22, 2019
@JohnZed JohnZed moved this from Issue-Needs prioritizing to Issue-P1 in v0.9 Release Jun 27, 2019
@JohnZed JohnZed moved this from Issue-P1 to Defer to post-0.9 in v0.9 Release Aug 12, 2019
@dantegd dantegd added this to Issue- Needs Prioritizing in v0.10 Release via automation Aug 12, 2019
@dantegd dantegd removed this from Defer to post-0.9 in v0.9 Release Aug 12, 2019
@JohnZed JohnZed moved this from Issue- Needs Prioritizing to Defer Post 0.10 in v0.10 Release Sep 24, 2019
@cjnolet cjnolet added this to Issue-Needs prioritizing in v0.11 Release via automation Oct 10, 2019
@cjnolet cjnolet removed this from Defer Post 0.10 in v0.10 Release Oct 10, 2019
@cjnolet cjnolet added this to Issue-Needs prioritizing in v0.12 Release via automation Nov 21, 2019
@cjnolet cjnolet removed this from Issue-Needs prioritizing in v0.11 Release Nov 21, 2019
@mike-wendt mike-wendt added this to Needs prioritizing in Feature Planning Feb 13, 2020
@fondaing fondaing added this to Issue-Needs prioritizing in v0.13 Release via automation Mar 5, 2020
@fondaing fondaing removed this from Issue-Needs prioritizing in v0.12 Release Mar 5, 2020
@fondaing fondaing added this to Issue-Needs prioritizing in v0.14 Release via automation Apr 3, 2020
@fondaing fondaing removed this from Issue-Needs prioritizing in v0.13 Release Apr 3, 2020
@fondaing fondaing removed this from Issue-Needs prioritizing in v0.14 Release Jun 9, 2020
@fondaing fondaing added this to Issue-Needs prioritizing in v0.15 Release via automation Jun 9, 2020
@fondaing fondaing added this to Issue-Needs prioritizing in v0.16 Release via automation Sep 24, 2020
@fondaing fondaing removed this from Issue-Needs prioritizing in v0.15 Release Sep 24, 2020
@fondaing fondaing added this to Issue-Needs prioritizing in v0.17 Release via automation Oct 26, 2020
@fondaing fondaing removed this from Needs prioritizing in Feature Planning Oct 26, 2020
@fondaing fondaing removed this from Issue-Needs prioritizing in v0.16 Release Oct 26, 2020
@JohnZed JohnZed added this to To do in Tech Debt / Quality of Life via automation Jan 4, 2021
@JohnZed JohnZed removed this from Issue-Needs prioritizing in v0.17 Release Jan 4, 2021
@JohnZed JohnZed added this to Issue-Needs prioritizing in v0.18 Release via automation Jan 4, 2021
@JohnZed JohnZed removed this from To do in Tech Debt / Quality of Life Jan 4, 2021
@caryr35 caryr35 added this to Issue-Needs prioritizing in v21.06 Release via automation Mar 24, 2021
@caryr35 caryr35 removed this from Issue-Needs prioritizing in v0.18 Release Mar 24, 2021
@dantegd dantegd moved this from Issue-Needs prioritizing to Defer to post-0.20 in v21.06 Release May 20, 2021
@caryr35 caryr35 added this to Issue-Needs prioritizing in v21.08 Release via automation Jun 4, 2021
@caryr35 caryr35 removed this from Defer to post-21.08 in v21.06 Release Jun 4, 2021
@caryr35 caryr35 moved this from Issue-Needs prioritizing to Defer to post-21.11 in v21.08 Release Jun 4, 2021
@dantegd dantegd moved this from Defer to post-21.08 to Issue-Needs prioritizing in v21.08 Release Jun 17, 2021
@caryr35 caryr35 removed this from Issue-Needs prioritizing in v21.08 Release Aug 4, 2021
@caryr35 caryr35 added this to Issue-Needs prioritizing in v21.10 Release via automation Aug 4, 2021
@caryr35 caryr35 removed this from Issue-Needs prioritizing in v21.10 Release Oct 4, 2021
@caryr35 caryr35 added this to Issue-Needs prioritizing in v21.12 Release via automation Oct 4, 2021
@caryr35 caryr35 removed this from Issue-Needs prioritizing in v21.12 Release Dec 15, 2021
@caryr35 caryr35 added this to Issue-Needs prioritizing in v22.02 Release via automation Dec 15, 2021
@caryr35 caryr35 removed this from Issue-Needs prioritizing in v22.02 Release Feb 8, 2022
@caryr35 caryr35 added this to Issue-Needs prioritizing in v22.04 Release via automation Feb 8, 2022
@caryr35 caryr35 removed this from Issue-Needs prioritizing in v22.04 Release Apr 12, 2022
@caryr35 caryr35 added this to Issue-Needs prioritizing in v22.06 Release via automation Apr 12, 2022
@caryr35 caryr35 removed this from Issue-Needs prioritizing in v22.06 Release Jun 16, 2022
@caryr35 caryr35 added this to Issue-Needs prioritizing in v22.08 Release via automation Jun 16, 2022
@caryr35 caryr35 removed this from Issue-Needs prioritizing in v22.08 Release Aug 9, 2022
@caryr35 caryr35 added this to Issue-Needs prioritizing in v22.10 Release via automation Aug 9, 2022
@beckernick beckernick mentioned this issue Sep 12, 2022
Merged
@rapids-bot rapids-bot bot closed this as completed in 96da84c Sep 29, 2022
v22.10 Release automation moved this from Issue-Needs prioritizing to Done Sep 29, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this issue Feb 27, 2023
@VamsiTallam95
Transforms RandomForest estimators non-consecutive labels to consecut…
0c5988d 
…ive labels where appropriate (rapidsai#4780)

This PR closes rapidsai#4478 by transforming non-consecutive labels outside of [0,n) to consecutive labels inside [0,n) similar to what Scikit-learn does under the hood.

Closes rapidsai#691

Authors:
  - https://github.com/VamsiTallam95

Approvers:
  - Micka (https://github.com/lowener)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#4780
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
? - Needs Triage Need team to review and classify feature request New feature or request
Projects
No open projects
v22.10 Release
  
Done
Milestone
No milestone
3 participants
@teju85 @Salonijain27 @myrtw