Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] New Feature StratifiedKFold #3109

Merged
merged 24 commits into from Sep 22, 2022
Merged

[REVIEW] New Feature StratifiedKFold #3109

merged 24 commits into from Sep 22, 2022

Conversation

daxiongshu
Copy link
Contributor

Add equivalent of sklearn's StratifiedKFold to cuml.

@daxiongshu daxiongshu requested a review from a team as a code owner November 1, 2020 14:58
@codecov-io
Copy link

Codecov Report

Merging #3109 into branch-0.17 will decrease coverage by 0.20%.
The diff coverage is 11.11%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17    #3109      +/-   ##
===============================================
- Coverage        59.20%   58.99%   -0.21%     
===============================================
  Files              142      142              
  Lines             8966     9002      +36     
===============================================
+ Hits              5308     5311       +3     
- Misses            3658     3691      +33
Impacted Files Coverage Δ
python/cuml/preprocessing/model_selection.py 78.20% <11.11%> (-12.20%) ⬇️
...l/_thirdparty/sklearn/preprocessing/_imputation.py 62.09% <0.00%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e6d413...7162d2a. Read the comment docs.

@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@dantegd dantegd added 2 - In Progress Currenty a work in progress Cython / Python Cython or Python issue labels Nov 2, 2020
@daxiongshu daxiongshu requested review from a team as code owners December 28, 2020 02:31
@ajschmidt8
Copy link
Member

@daxiongshu, is there any reason this PR is targeting branch-0.17? If not, can you update it to target the latest branch, branch-0.18? Thanks!

@github-actions
Copy link

This PR has been marked stale due to no recent activity in the past 30d. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be marked rotten if there is no activity in the next 60d.

@caryr35 caryr35 added this to PR-WIP in v21.06 Release via automation Apr 7, 2021
@github-actions
Copy link

This PR has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates.

@caryr35 caryr35 removed this from PR-WIP in v21.06 Release Jun 4, 2021
@caryr35 caryr35 added this to PR-WIP in v21.08 Release via automation Jun 4, 2021
@dantegd dantegd removed this from PR-WIP in v21.08 Release Jul 27, 2021
@dantegd dantegd added this to PR-WIP in v21.10 Release via automation Jul 27, 2021
@caryr35 caryr35 added this to PR-WIP in v21.12 Release via automation Oct 4, 2021
@caryr35 caryr35 removed this from PR-WIP in v21.10 Release Oct 4, 2021
@caryr35 caryr35 added this to PR-WIP in v22.02 Release via automation Dec 15, 2021
@caryr35 caryr35 removed this from PR-WIP in v21.12 Release Dec 15, 2021
@dantegd dantegd removed this from PR-WIP in v22.02 Release Jan 24, 2022
@dantegd dantegd added this to PR-WIP in v22.04 Release via automation Jan 24, 2022
@daxiongshu
Copy link
Contributor Author

rerun test

@daxiongshu
Copy link
Contributor Author

rerun tests

@daxiongshu daxiongshu changed the base branch from branch-22.04 to branch-22.06 April 1, 2022 03:31
@caryr35 caryr35 added this to PR-WIP in v22.06 Release via automation Apr 12, 2022
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v22.06 Release Apr 12, 2022
@caryr35 caryr35 removed this from PR-Needs review in v22.04 Release Apr 12, 2022
@cjnolet cjnolet removed this from PR-Needs review in v22.06 Release May 24, 2022
@cjnolet cjnolet added this to PR-WIP in v22.08 Release via automation May 24, 2022
@caryr35 caryr35 removed this from PR-WIP in v22.08 Release Aug 9, 2022
@caryr35 caryr35 added this to PR-WIP in v22.10 Release via automation Aug 9, 2022
@dantegd dantegd changed the base branch from branch-22.06 to branch-22.10 August 31, 2022 17:32
@dantegd
Copy link
Member

dantegd commented Sep 21, 2022

rerun tests

v22.10 Release automation moved this from PR-WIP to PR-Reviewer approved Sep 21, 2022
@dantegd
Copy link
Member

dantegd commented Sep 22, 2022

rerun tests

@dantegd
Copy link
Member

dantegd commented Sep 22, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 56bb5a2 into rapidsai:branch-22.10 Sep 22, 2022
v22.10 Release automation moved this from PR-Reviewer approved to Done Sep 22, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@daxiongshu
New Feature StratifiedKFold (rapidsai#3109)
b7b1a67 
Add equivalent of [sklearn's StratifiedKFold](https://scikit-learn.org/stable/modules/generated/sklearn.model_selection.StratifiedKFold.html) to `cuml`.

Authors:
  - Jiwei Liu (https://github.com/daxiongshu)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#3109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
4 - Waiting on Author Waiting for author to respond to review Cython / Python Cython or Python issue feature request New feature or request non-breaking Non-breaking change
Projects
No open projects
v22.10 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@daxiongshu @codecov-io @GPUtester @ajschmidt8 @dantegd