Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColumnTransformer & FunctionTransformer #3745

Merged
merged 49 commits into from
May 29, 2021
Merged

ColumnTransformer & FunctionTransformer #3745

merged 49 commits into from
May 29, 2021

Conversation

viclafargue
Copy link
Contributor

Answers #3041

@viclafargue
cuML Base estimator class for preprocessing models
94d845f
@viclafargue
cuml_function decorator
653b9cf
@viclafargue
Cleaning code
4bf0c2d
@viclafargue
Adding missing tags
d8b56bc
@viclafargue
Merge branch 'branch-0.18' into fea-cuml-base-for-preproc
3545bfb
@viclafargue
Changelog update
d64c1d1
@viclafargue
Check style
ef74d52
@viclafargue
Updated adapters testing
ff1f419
@viclafargue
Relative imports
829eabc
@viclafargue
Remove cuml_function
4bcae89
@viclafargue
Remove cuml_estimator
ca93dc5
@viclafargue
Update get_param_names
dba3f37
@viclafargue
Update __init_subclass__
4ed8be3
@viclafargue
Update get_param_names
4b6bda4
@viclafargue
Exemption for docstring
031ecf4
@viclafargue
Restoring KernelCenterer, QuantileTransformer, and PowerTransformer code
f25ab52
@viclafargue
Update coding style
42b6475
@viclafargue
Merge branch 'branch-0.18' into fea-cuml-base-for-preproc
5827536
@viclafargue
Merge branch 'branch-0.18' into fea-cuml-base-for-preproc
96c64d4
@viclafargue
Tags deepcopy fix
0e467f8
@viclafargue
Fix for KBinsDiscretizer
298c3c3
@viclafargue
Merge branch 'branch-0.18' into fea-cuml-base-for-preproc
65d5226
@viclafargue
Merge branch 'branch-0.19' into fea-cuml-base-for-preproc
0e4f994
@viclafargue
Update copyright header
a18f5f6
@viclafargue
Remove changelog entry
7e15903
@viclafargue
Merge branch 'branch-0.19' into fea-cuml-base-for-preproc
ec001b5
@viclafargue
Requested changes
8603650
@viclafargue
Merge branch 'branch-0.19' into fea-cuml-base-for-preproc
dd09165
@viclafargue
Requested changes (2/2)
c30722e
@viclafargue
Merge branch 'branch-0.19' into fea-cuml-base-for-preproc
26c2ddd
@viclafargue viclafargue added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 19, 2021
@dantegd dantegd changed the title [WIP] ColumnTransformer & FunctionTransformer ColumnTransformer & FunctionTransformer Apr 23, 2021
@dantegd dantegd self-requested a review April 29, 2021 16:30
@caryr35 caryr35 added this to PR-WIP in v21.08 Release via automation May 3, 2021
v21.08 Release automation moved this from PR-WIP to PR-Needs review May 11, 2021
dantegd
dantegd requested changes May 11, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had one comment really, sorry for the delayed review

python/cuml/_thirdparty/sklearn/preprocessing/_function_transformer.py Show resolved Hide resolved
@dantegd dantegd added 4 - Waiting on Author Waiting for author to respond to review and removed 3 - Ready for Review Ready for review by team labels May 11, 2021
@viclafargue viclafargue added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 4 - Waiting on Author Waiting for author to respond to review labels May 20, 2021
@viclafargue viclafargue requested a review from dantegd May 27, 2021 16:30
@dantegd
Copy link
Member

dantegd commented May 28, 2021

rerun tests

v21.08 Release automation moved this from PR-Needs review to PR-Reviewer approved May 28, 2021
@dantegd
Copy link
Member

dantegd commented May 28, 2021

@gpucibot merge

@viclafargue
Copy link
Contributor Author

rerun tests

1 similar comment
@dantegd
Copy link
Member

dantegd commented May 28, 2021

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@1838ff2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #3745   +/-   ##
===============================================
  Coverage                ?   85.40%           
===============================================
  Files                   ?      229           
  Lines                   ?    18568           
  Branches                ?        0           
===============================================
  Hits                    ?    15858           
  Misses                  ?     2710           
  Partials                ?        0
Flag Coverage Δ
dask 48.39% <0.00%> (?)
non-dask 77.64% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1838ff2...41d8771. Read the comment docs.

@rapids-bot rapids-bot bot merged commit c05d7a2 into rapidsai:branch-21.06 May 29, 2021
v21.08 Release automation moved this from PR-Reviewer approved to Done May 29, 2021
@viclafargue viclafargue mentioned this pull request May 31, 2021
Closed
@codeananda codeananda mentioned this pull request Dec 3, 2021
Closed
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@viclafargue
ColumnTransformer & FunctionTransformer (rapidsai#3745)
2039462 
Answers rapidsai#3041

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#3745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
4 - Waiting on Reviewer Waiting for reviewer to review or respond Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v21.08 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@viclafargue @dantegd @codecov-commenter