Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MNMG test test_rf_regression_dask_fil[5-float32] #3830

Merged
merged 1 commit into from
May 22, 2021
Merged

Fix MNMG test test_rf_regression_dask_fil[5-float32] #3830

merged 1 commit into from
May 22, 2021

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented May 5, 2021

See #3820

@hcho3 hcho3 requested a review from a team as a code owner May 5, 2021 21:56
@hcho3 hcho3 mentioned this pull request May 5, 2021
Closed
@github-actions github-actions bot added the Cython / Python Cython or Python issue label May 5, 2021
@hcho3 hcho3 added non-breaking Non-breaking change tests Unit testing for project bug Something isn't working labels May 5, 2021
viclafargue
viclafargue approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@viclafargue viclafargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caryr35 caryr35 added this to PR-WIP in v21.06 Release via automation May 21, 2021
@dantegd dantegd changed the title Fix MNMG test test_rf_regression_dask_fil[5-float32] Fix MNMG test test_rf_regression_dask_fil[5-float32] May 22, 2021
v21.06 Release automation moved this from PR-WIP to PR-Reviewer approved May 22, 2021
dantegd
dantegd approved these changes May 22, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code owner approval

@dantegd
Copy link
Member

dantegd commented May 22, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3e89f04 into rapidsai:branch-21.06 May 22, 2021
v21.06 Release automation moved this from PR-Reviewer approved to Done May 22, 2021
@hcho3 hcho3 deleted the fix_mnmg_rf_test branch June 9, 2021 00:56
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@hcho3
Fix MNMG test test_rf_regression_dask_fil (rapidsai#3830)
d2e7269 
See rapidsai#3820

Authors:
  - Philip Hyunsu Cho (https://github.com/hcho3)

Approvers:
  - Victor Lafargue (https://github.com/viclafargue)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#3830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@viclafargue viclafargue viclafargue approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change tests Unit testing for project
Projects
No open projects
v21.06 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hcho3 @dantegd @viclafargue