Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for MNMG test_rf_classification_dask_fil_predict_proba #3831

Merged
merged 1 commit into from
May 22, 2021
Merged

Fix for MNMG test_rf_classification_dask_fil_predict_proba #3831

merged 1 commit into from
May 22, 2021

Conversation

lowener
Copy link
Contributor

@lowener lowener commented May 5, 2021

See #3820

@lowener lowener requested a review from a team as a code owner May 5, 2021 23:49
@github-actions github-actions bot added the Cython / Python Cython or Python issue label May 5, 2021
@lowener lowener mentioned this pull request May 5, 2021
Closed
@lowener lowener added bug Something isn't working non-breaking Non-breaking change tests Unit testing for project labels May 5, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3831 (7cb26c0) into branch-0.20 (46174b7) will increase coverage by 0.06%.
The diff coverage is 81.11%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #3831      +/-   ##
===============================================
+ Coverage        85.96%   86.03%   +0.06%     
===============================================
  Files              225      225              
  Lines            16986    17116     +130     
===============================================
+ Hits             14602    14725     +123     
- Misses            2384     2391       +7
Flag Coverage Δ
dask 49.28% <23.33%> (+0.32%) ⬆️
non-dask 77.93% <80.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/common/memory_utils.py 79.26% <ø> (+0.51%) ⬆️
python/cuml/dask/common/utils.py 43.68% <0.00%> (ø)
python/cuml/ensemble/randomforestclassifier.pyx 83.61% <ø> (ø)
python/cuml/linear_model/logistic_regression.pyx 89.21% <ø> (ø)
python/cuml/neighbors/nearest_neighbors.pyx 93.11% <ø> (-0.03%) ⬇️
python/cuml/tsa/auto_arima.pyx 57.48% <0.00%> (-0.53%) ⬇️
python/cuml/manifold/t_sne.pyx 78.34% <76.31%> (-1.00%) ⬇️
python/cuml/dask/common/dask_arr_utils.py 95.83% <100.00%> (+0.05%) ⬆️
python/cuml/fil/fil.pyx 92.55% <100.00%> (-0.31%) ⬇️
python/cuml/metrics/confusion_matrix.py 95.34% <100.00%> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e125c62...7cb26c0. Read the comment docs.

viclafargue
viclafargue approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@viclafargue viclafargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lowener lowener added the 3 - Ready for Review Ready for review by team label May 14, 2021
@lowener
Copy link
Contributor Author

lowener commented May 17, 2021

Fail message: assert 0.052289582249832274 <= (0.02975565844134763 + 0.022)

By changing the tolerance from 0.022 to 0.029 I was able to consistently pass this test with 8 GPU on a cloud instance.

@lowener lowener changed the title Fix MNMG test_rf_classification_dask_fil_predict_proba Fix for MNMG test_rf_classification_dask_fil_predict_proba May 20, 2021
@dantegd
Copy link
Member

dantegd commented May 22, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ea662e8 into rapidsai:branch-21.06 May 22, 2021
@lowener lowener deleted the 020_fix_mnmg_rf_classif branch May 23, 2021 20:51
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@lowener
Fix for MNMG test_rf_classification_dask_fil_predict_proba (rapidsai#…
7e6631c 
…3831)

See rapidsai#3820

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Victor Lafargue (https://github.com/viclafargue)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#3831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@viclafargue viclafargue viclafargue approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lowener @codecov-commenter @dantegd @viclafargue