Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Make sure __init__ is called in graph callback. #3881

Merged
merged 2 commits into from
May 20, 2021
Merged

[REVIEW] Make sure __init__ is called in graph callback. #3881

merged 2 commits into from
May 20, 2021

Conversation

trivialfis
Copy link
Member

I made the mistake and got a segmentation fault. A value error might be nicer.

@trivialfis trivialfis added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 20, 2021
@trivialfis trivialfis requested a review from a team as a code owner May 20, 2021 18:51
@github-actions github-actions bot added the Cython / Python Cython or Python issue label May 20, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@909ee29). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #3881   +/-   ##
===============================================
  Coverage                ?   85.41%           
===============================================
  Files                   ?      227           
  Lines                   ?    17315           
  Branches                ?        0           
===============================================
  Hits                    ?    14790           
  Misses                  ?     2525           
  Partials                ?        0
Flag Coverage Δ
dask 48.92% <0.00%> (?)
non-dask 77.36% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909ee29...5d06a83. Read the comment docs.

cjnolet
cjnolet approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cjnolet cjnolet added this to PR-WIP in v21.06 Release via automation May 20, 2021
@cjnolet
Copy link
Member

cjnolet commented May 20, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b7a634a into rapidsai:branch-21.06 May 20, 2021
v21.06 Release automation moved this from PR-WIP to Done May 20, 2021
@trivialfis trivialfis deleted the enh-check-callback-init branch May 21, 2021 01:52
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@trivialfis
Make sure __init__ is called in graph callback. (rapidsai#3881)
e5a2ac6 
I made the mistake and got a segmentation fault.  A value error might be nicer.

Authors:
  - Jiaming Yuan (https://github.com/trivialfis)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#3881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v21.06 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trivialfis @codecov-commenter @cjnolet