Condense TSNE parameters into a struct #3884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowener
added
3 - Ready for Review
cjnolet
approved these changes
May 20, 2021
python/cuml/manifold/t_sne.pyx
Outdated
| @@ -509,6 +492,30 @@ class TSNE(Base, | |||
| raise ValueError("Allowed methods are 'exact', 'barnes_hut' and " | |||
| "'fft'.") | |||
|
|
|||
| cdef TSNEParams params | |||
There was a problem hiding this comment.
Just a tiny nitpick- it might clean this method up even further if the TSNE class had a method like _build_tsne_params that could run this logic.
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #3884 +/- ##
===============================================
Coverage ? 85.40%
===============================================
Files ? 227
Lines ? 17297
Branches ? 0
===============================================
Hits ? 14772
Misses ? 2525
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
lowener
added
4 - Waiting on Reviewer
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Closes rapidsai#3781 Authors: - Micka (https://github.com/lowener) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#3884
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3781