Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add type check for y in train_test_split #3886

Merged
merged 5 commits into from
May 24, 2021
Merged

[REVIEW] Add type check for y in train_test_split #3886

merged 5 commits into from
May 24, 2021

Conversation

Nanthini10
Copy link
Contributor

Closes #3817

Combing the train and test blocks and checking for type of y before applying the split.

@Nanthini10 Nanthini10 requested a review from a team as a code owner May 21, 2021 16:50
@github-actions github-actions bot added the Cython / Python Cython or Python issue label May 21, 2021
@Nanthini10 Nanthini10 added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels May 21, 2021
@caryr35 caryr35 added this to PR-WIP in v21.06 Release via automation May 21, 2021
dantegd
dantegd requested changes May 21, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I was wondering if we could add a simple test case could be added?

v21.06 Release automation moved this from PR-WIP to PR-Needs review May 21, 2021
@dantegd dantegd added 4 - Waiting on Author Waiting for author to respond to review and removed 3 - Ready for Review Ready for review by team labels May 21, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@05124c4). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 9a9fdf4 differs from pull request most recent head a02a451. Consider uploading reports for the commit a02a451 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #3886   +/-   ##
===============================================
  Coverage                ?   85.41%           
===============================================
  Files                   ?      227           
  Lines                   ?    17315           
  Branches                ?        0           
===============================================
  Hits                    ?    14790           
  Misses                  ?     2525           
  Partials                ?        0
Flag Coverage Δ
dask 48.92% <0.00%> (?)
non-dask 77.36% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05124c4...a02a451. Read the comment docs.

@Nanthini10 Nanthini10 added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 4 - Waiting on Author Waiting for author to respond to review labels May 24, 2021
v21.06 Release automation moved this from PR-Needs review to PR-Reviewer approved May 24, 2021
@dantegd
Copy link
Member

dantegd commented May 24, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 91e1e92 into rapidsai:branch-21.06 May 24, 2021
v21.06 Release automation moved this from PR-Reviewer approved to Done May 24, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@Nanthini10
Add type check for y in train_test_split (rapidsai#3886)
e18ad10 
Closes rapidsai#3817

Combing the train and test blocks and checking for type of y before applying the split.

Authors:
  - Nanthini (https://github.com/Nanthini10)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#3886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
4 - Waiting on Reviewer Waiting for reviewer to review or respond bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
No open projects
v21.06 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] train_test_split fails if X is a dataframe and y is an array
3 participants
@Nanthini10 @codecov-commenter @dantegd