Correct install path for include folder to avoid double nesting #3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wphicks
approved these changes
May 26, 2021
JohnZed
approved these changes
May 26, 2021
|
rerun tests |
raydouglass
approved these changes
May 26, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #3901 +/- ##
===============================================
Coverage ? 85.42%
===============================================
Files ? 226
Lines ? 17271
Branches ? 0
===============================================
Hits ? 14754
Misses ? 2517
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
wphicks
added a commit
to triton-inference-server/fil_backend
that referenced
this pull request
May 26, 2021
Include cuML header directory that is currently nested one layer too deep (to be fixed by rapidsai/cuml#3901) Ignore unused variable warnings due to unused variable in fil.h introduced by rapidsai/cuml#3763
|
rerun tests |
|
@gpucibot merge |
wphicks
added a commit
to triton-inference-server/fil_backend
that referenced
this pull request
May 28, 2021
* Temporary fix for upstream cuML issues Include cuML header directory that is currently nested one layer too deep (to be fixed by rapidsai/cuml#3901) Ignore unused variable warnings due to unused variable in fil.h introduced by rapidsai/cuml#3763 * Remove extra include path following upstream fix * Update to CalVer for cuML
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Jun 1, 2021
Similar to rapidsai/cuml#3901. After #1491 and #rapids-cmake and #1585, now at install time, the cugraph headers are being nested into `path/to/env/include/cugraph/cugraph` instead of just `path/to/env/include/cugraph/`. This, as far as I'm aware, is unintentional and unlike the rest of RAPIDS projects (cuDF, RMM and cuML). cc @trxcllnt @robertmaynard Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - Chuck Hastings (https://github.com/ChuckHastings) - Robert Maynard (https://github.com/robertmaynard) - Seunghwa Kang (https://github.com/seunghwak) - Paul Taylor (https://github.com/trxcllnt) - Rick Ratzel (https://github.com/rlratzel) URL: #1630
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
…dsai#3901) Small oversight with the CMake changes, there already is a `cuml` folder in our `cpp/include`, so we were double nesting it. After the fix we're back to the old (expected) behavior, and consistent with RMM and cuDF. cc @hcho3 @wphicks Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - William Hicks (https://github.com/wphicks) - John Zedlewski (https://github.com/JohnZed) - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#3901
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small oversight with the CMake changes, there already is a
cumlfolder in ourcpp/include, so we were double nesting it. After the fix we're back to the old (expected) behavior, and consistent with RMM and cuDF.cc @hcho3 @wphicks