Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade NCCL to 2.9.9 #3902

Merged
merged 7 commits into from
Jun 4, 2021
Merged

Upgrade NCCL to 2.9.9 #3902

merged 7 commits into from
Jun 4, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented May 26, 2021

No description provided.

@dantegd dantegd added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 26, 2021
@dantegd dantegd requested a review from a team as a code owner May 26, 2021 15:28
@github-actions github-actions bot added conda conda issue gpuCI gpuCI issue labels May 26, 2021
@cjnolet
Copy link
Member

cjnolet commented May 26, 2021

Looks like the CI failures here are related to recent Dask changes, which were recently fixed here?

Going to rerun tests to see.

@cjnolet
Copy link
Member

cjnolet commented May 26, 2021

rerun tests

1 similar comment
@dantegd
Copy link
Member Author

dantegd commented May 27, 2021

rerun tests

@dantegd
Copy link
Member Author

dantegd commented May 28, 2021

rerun tests

jakirkham
jakirkham reviewed May 28, 2021
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swapping which one is dev installed

ci/gpu/build.sh Outdated Show resolved Hide resolved
ci/gpu/build.sh Outdated Show resolved Hide resolved
@dantegd dantegd changed the title Testing upgrade NCCL to 2.9.9 Testing upgrade NCCL to 2.9.9 [skip-ci] May 28, 2021
@dantegd @jakirkham
Update ci/gpu/build.sh
fe4318f 
Co-authored-by: jakirkham <jakirkham@gmail.com>
@dantegd dantegd changed the title Testing upgrade NCCL to 2.9.9 [skip-ci] Testing upgrade NCCL to 2.9.9 May 28, 2021
@dantegd @jakirkham
Update ci/gpu/build.sh
f6c7540 
Co-authored-by: jakirkham <jakirkham@gmail.com>
jakirkham
jakirkham reviewed May 28, 2021
View reviewed changes
ci/gpu/build.sh Outdated
gpuci_logger "Install the main version of dask and distributed"
set -x
pip install "git+https://github.com/dask/distributed.git@main" --upgrade --no-deps
pip install "git+https://github.com/jakirkham/distributed.git@drop_whowhat_client" --upgrade --no-deps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be reverted once ready as it is merged

Suggested change
pip install "git+https://github.com/jakirkham/distributed.git@drop_whowhat_client" --upgrade --no-deps
pip install "git+https://github.com/dask/distributed.git@main" --upgrade --no-deps

@dantegd dantegd changed the title Testing upgrade NCCL to 2.9.9 Upgrading NCCL to 2.9.9 May 28, 2021
@dantegd dantegd changed the title Upgrading NCCL to 2.9.9 Upgrade NCCL to 2.9.9 May 28, 2021
@dantegd
Copy link
Member Author

dantegd commented May 29, 2021

Note: PR is waiting for an equivalent in integration

@github-actions github-actions bot removed the gpuCI gpuCI issue label May 31, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@95efa25). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #3902   +/-   ##
===============================================
  Coverage                ?   85.07%           
===============================================
  Files                   ?      228           
  Lines                   ?    17775           
  Branches                ?        0           
===============================================
  Hits                    ?    15122           
  Misses                  ?     2653           
  Partials                ?        0
Flag Coverage Δ
dask 48.18% <0.00%> (?)
non-dask 77.26% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95efa25...be75d19. Read the comment docs.

@cjnolet
Copy link
Member

cjnolet commented Jun 1, 2021

This change has been approved, is it good to go for the release?

@dantegd
Copy link
Member Author

dantegd commented Jun 1, 2021

It's just waiting on rapidsai/integration#287 so that CI doesn't get issues after the merge

@dantegd dantegd added this to PR-WIP in v21.06 Release via automation Jun 2, 2021
@dantegd dantegd moved this from PR-WIP to PR-Reviewer approved in v21.06 Release Jun 3, 2021
@dantegd
Copy link
Member Author

dantegd commented Jun 4, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c27f132 into rapidsai:branch-21.06 Jun 4, 2021
v21.06 Release automation moved this from PR-Reviewer approved to Done Jun 4, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@dantegd
Upgrade NCCL to 2.9.9 (rapidsai#3902)
f6ecca3 
Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Jordan Jacobelli (https://github.com/Ethyling)

URL: rapidsai#3902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham left review comments

@jjacobelli jjacobelli jjacobelli approved these changes

Assignees
No one assigned
Labels
conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v21.06 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dantegd @cjnolet @codecov-commenter @jakirkham @jjacobelli