Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation build examples to be generator agnostic #3909

Conversation

robertmaynard
Copy link
Contributor

Now that the default CMake generator used by build.sh is Ninja we should provide generator agnostic build instructions.

Now that the default CMake generator used by `build.sh` is Ninja
we should provide generator agnostic build instructions.
@robertmaynard robertmaynard requested a review from a team as a code owner May 27, 2021 15:13
@cjnolet cjnolet added non-breaking Non-breaking change doc Documentation feature request New feature or request labels May 28, 2021
@dantegd dantegd added this to PR-WIP in v21.06 Release via automation May 28, 2021
@dantegd dantegd removed this from PR-WIP in v21.06 Release May 28, 2021
@dantegd dantegd added this to PR-WIP in v21.08 Release via automation May 28, 2021
@dantegd dantegd removed the feature request New feature or request label May 28, 2021
@dantegd
Copy link
Member

dantegd commented May 28, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fa161de into rapidsai:branch-21.08 May 28, 2021
v21.08 Release automation moved this from PR-WIP to Done May 28, 2021
@robertmaynard robertmaynard deleted the update_cpp_readme_compile_lines_to_use_cmake branch June 1, 2021 12:35
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
…i#3909)

Now that the default CMake generator used by `build.sh` is Ninja we should provide generator agnostic build instructions.

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#3909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CUDA/C++ doc Documentation non-breaking Non-breaking change
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants