[REVIEW] Fix for multi GPU PCA compute failing bug after transform and added error handling when n_components is not passed #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #3913 |
lowener
requested changes
May 29, 2021
There was a problem hiding this comment.
Thanks for the fix it's a good catch. Regarding n_components, it was set to 1 in single GPU before 0.16, after it was decided to set this parameter to min(n_cols, n_rows) so we should try to stay consistent here and always set it by default to min(n_cols, n_rows).
…PU version. Fixed styling.
|
rerun tests |
akaanirban
changed the title
|
rerun tests |
1 similar comment
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #3912 +/- ##
===============================================
Coverage ? 85.32%
===============================================
Files ? 230
Lines ? 18096
Branches ? 0
===============================================
Hits ? 15440
Misses ? 2656
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Nanthini10
added
5 - Ready to Merge
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
…rror handling when n_components is not passed (rapidsai#3912) This PR fixes rapidsai#3913 where Multi GPU PCA is failing on calling compute() after transform. This fix is similar to what has been done in a previous PR rapidsai#3320 . The current PR : 1. Fixes the problem of `AttributeError` when calling `compute()` after `transform()` while using `cuml.dask.decomposition.PCA` 2. Added setting of `n_components=1` when n_components is not set in the multi GPU case. (The tests were failing if I don't set n_components, however, I did not find a place where n_component is set to 1. I may be wrong. PR rapidsai#3320 seems to fix `n_component=min(n_cols, n_rows` as of 0.16 for single GPU. Not entirely sure if that should also be the case for MG as well. ) 3. Added test cases for the above two changes. Authors: - Anirban Das (https://github.com/akaanirban) Approvers: - Micka (https://github.com/lowener) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#3912
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3913 where Multi GPU PCA is failing on calling compute() after transform.
This fix is similar to what has been done in a previous PR #3320 . The current PR :
AttributeErrorwhen callingcompute()aftertransform()while usingcuml.dask.decomposition.PCAn_components=1when n_components is not set in the multi GPU case. (The tests were failing if I don't set n_components, however, I did not find a place where n_component is set to 1. I may be wrong. PR Fix for default arguments of PCA #3320 seems to fixn_component=min(n_cols, n_rowsas of 0.16 for single GPU. Not entirely sure if that should also be the case for MG as well. )