Fix number of permutations in pytest and getting handle for cuml models #3920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at have handle as none
|
Strange ARIMA cython build error in CI. Strange it's in a fresh environment though and in an unrelated PR: |
|
I think it was bad timing, the arima PR got merged at a moment that made things fail, I think rerunning tests should be enough |
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #3920 +/- ##
===============================================
Coverage ? 85.19%
===============================================
Files ? 228
Lines ? 17928
Branches ? 0
===============================================
Hits ? 15273
Misses ? 2655
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
…ls (rapidsai#3920) Closes rapidsai#3819 Bug fixes: - Increase npermutations in pytest (and reduce number of tests a bit), to avoid sporadic failure - Simplified code in common avoids a problem for cuML models that have handle as `none` (Naive Bayes) Authors: - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#3920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3819
Bug fixes:
none(Naive Bayes)