Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin dask ot 2021.5.1 for 21.06 release #3937

Merged
merged 2 commits into from
Jun 3, 2021
Merged

Pin dask ot 2021.5.1 for 21.06 release #3937

merged 2 commits into from
Jun 3, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Jun 3, 2021

No description provided.

@dantegd dantegd added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 3, 2021
@dantegd dantegd requested a review from a team as a code owner June 3, 2021 02:29
@dantegd dantegd added this to PR-WIP in v21.06 Release via automation Jun 3, 2021
@github-actions github-actions bot added conda conda issue gpuCI gpuCI issue labels Jun 3, 2021
jakirkham
jakirkham reviewed Jun 3, 2021
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dante! 😄

Had one question below 🙂

conda/environments/cuml_dev_cuda11.0.yml Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@42297b5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #3937   +/-   ##
===============================================
  Coverage                ?   85.17%           
===============================================
  Files                   ?      228           
  Lines                   ?    17933           
  Branches                ?        0           
===============================================
  Hits                    ?    15274           
  Misses                  ?     2659           
  Partials                ?        0
Flag Coverage Δ
dask 47.81% <0.00%> (?)
non-dask 77.44% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42297b5...a314513. Read the comment docs.

v21.06 Release automation moved this from PR-WIP to PR-Reviewer approved Jun 3, 2021
@dantegd
Copy link
Member Author

dantegd commented Jun 3, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0d7a7b4 into rapidsai:branch-21.06 Jun 3, 2021
v21.06 Release automation moved this from PR-Reviewer approved to Done Jun 3, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@dantegd
Pin dask ot 2021.5.1 for 21.06 release (rapidsai#3937)
7123fcc 
Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Jordan Jacobelli (https://github.com/Ethyling)

URL: rapidsai#3937
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham left review comments

@jjacobelli jjacobelli jjacobelli approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team conda conda issue gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v21.06 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dantegd @codecov-commenter @jakirkham @jjacobelli